[coreboot-gerrit] Patch merged into coreboot/master: libpayload: usb: don't prematurely free the usb device

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 13 16:34:14 CEST 2015


the following patch was just integrated into master:
commit e3260ec29a0bce2d57ba66b99ea1d87a56e1e18a
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Jul 31 17:08:00 2015 -0500

    libpayload: usb: don't prematurely free the usb device
    
    Before the controller's destroy_device() could interrogate
    the usbdev_t object usb_detach_device() was freeing and
    NULLing out the pointer. That results in all callers who
    needed that object to start accessing random bits of memory.
    
    This eventually led into free()ing memory it shouldn't which
    corrupted the allocator's state. Eventually, all forward
    progress was lost by way of a single ended linked list
    turning into a circular list.
    
    The culprit seems to be a bad merge in commit e00ba21.
    
    BUG=chrome-os-partner:43419
    BRANCH=None
    TEST=Can boot into OS now w/o "hanging" on glados.
    
    Original-Change-Id: I86dcaa1dbaf112ac6782e90dad40f0932f273a1f
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/290048
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    
    Change-Id: I9135eb0f798bf7dbeccc7a033c3f8471720a0de5
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11173
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/11173 for details.

-gerrit



More information about the coreboot-gerrit mailing list