[coreboot-gerrit] New patch to review for coreboot: d629374 Kconfig cleanups

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Apr 27 22:41:45 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10012

-gerrit

commit d629374564d0e0a50cfc2aabfa51e9dee1b58678
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Apr 27 13:40:16 2015 -0700

    Kconfig cleanups
    
    Change-Id: I25ea327ed151e18ccb5d13626d44925d2a253d08
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/Kconfig         |  1 +
 src/cpu/x86/Kconfig | 23 ++++++++++++++---------
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index a6032c7..e77db23 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -305,6 +305,7 @@ source "src/device/Kconfig"
 
 menu "Generic Drivers"
 source "src/drivers/*/Kconfig"
+source "src/drivers/*/*/Kconfig"
 endmenu
 
 config TPM
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig
index 41c2288..689170b 100644
--- a/src/cpu/x86/Kconfig
+++ b/src/cpu/x86/Kconfig
@@ -1,7 +1,16 @@
+# TODO These two options look too similar
 config PARALLEL_CPU_INIT
 	bool
 	default n
 
+config PARALLEL_MP
+	def_bool n
+	help
+	 This option uses common MP infrastructure for bringing up APs
+	 in parallel. It additionally provides a more flexible mechanism
+	 for sequencing the steps of bringing up the APs.
+
+
 config UDELAY_IO
 	bool
 	default y if !UDELAY_LAPIC && !UDELAY_TSC && !UDELAY_TIMER2
@@ -39,11 +48,14 @@ config TSC_MONOTONIC_TIMER
 	help
 	  Expose monotonic time using the TSC.
 
-config UDELAY_TIMER2
+# This option is used in code but never selected.
+config TSC_CALIBRATE_WITH_IO
 	bool
+	depends on UDELAY_TSC
 	default n
 
-config TSC_CALIBRATE_WITH_IO
+# This option is used in code but never selected.
+config UDELAY_TIMER2
 	bool
 	default n
 
@@ -112,13 +124,6 @@ config PLATFORM_USES_FSP
 	  Selected for Intel processors/platform combinations that use the
 	  Intel Firmware Support Package (FSP) for initialization.
 
-config PARALLEL_MP
-	def_bool n
-	help
-	 This option uses common MP infrastructure for bringing up APs
-	 in parallel. It additionally provides a more flexible mechanism
-	 for sequencing the steps of bringing up the APs.
-
 config BACKUP_DEFAULT_SMM_REGION
 	def_bool n
 	help



More information about the coreboot-gerrit mailing list