[coreboot-gerrit] Patch set updated for coreboot: 5e24669 make: avoid problems with mv aliases

Vadim Bendebury (vbendeb@chromium.org) gerrit at coreboot.org
Sun Apr 26 21:55:56 CEST 2015


Vadim Bendebury (vbendeb at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9994

-gerrit

commit 5e246698f4073af5b46aeb1f34a86bbb6f7c9411
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Sat Apr 25 11:34:35 2015 -0700

    make: avoid problems with mv aliases
    
    Make fails to update .xcompile in case there is an mv alias preventing
    silent overwrites of existing files. To avoid ambiguity, invoke mv
    from standard location.
    
    Tested by touching util/xcompile/xcompile and/or running 'make
    oldconfig' a few times. .xcompile gets properly regenerated when
    required.
    
    Change-Id: Iedc5e288fbcc5dfc18ce39de5c067bb869a13275
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 14e1598..d428bf2 100644
--- a/Makefile
+++ b/Makefile
@@ -35,7 +35,8 @@
 $(if $(wildcard .xcompile),,$(eval $(shell util/xcompile/xcompile $(XGCCPATH) > .xcompile)))
 
 .xcompile: util/xcompile/xcompile
-	A=`mktemp $@.XXXXXX`; $< $(XGCCPATH) > $$A && mv $$A $@ 2> /dev/null
+	A=`mktemp $@.XXXXXX`; $< $(XGCCPATH) > $$A && \
+	/bin/mv -f $$A $@ 2> /dev/null
 
 include .xcompile
 



More information about the coreboot-gerrit mailing list