[coreboot-gerrit] New patch to review for coreboot: 0b11c62 lint: remove test for build dir handling

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Apr 24 13:40:25 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9988

-gerrit

commit 0b11c62ac98333f08fe14770922bd86c0c0f33fb
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Apr 24 13:39:19 2015 +0200

    lint: remove test for build dir handling
    
    This test outlives its usefulness and only slows down commits.
    We can now be confident that out-of-tree builds work because
    some of our automated builders do them regularly.
    
    Change-Id: I7c27e613ddd16f7bacbd4e232596b8a76e0c3301
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 util/lint/lint-stable-002-build-dir-handling | 73 ----------------------------
 1 file changed, 73 deletions(-)

diff --git a/util/lint/lint-stable-002-build-dir-handling b/util/lint/lint-stable-002-build-dir-handling
deleted file mode 100755
index 013d84a..0000000
--- a/util/lint/lint-stable-002-build-dir-handling
+++ /dev/null
@@ -1,73 +0,0 @@
-#!/bin/sh
-# This file is part of the coreboot project.
-#
-# Copyright (C) 2011 Patrick Georgi <patrick at georgi-clan.de>
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; version 2 of the License.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# DESCR: Check that build directories can be chosen freely
-
-# $1: command to test for GNU make
-search_make() {
-if [ -n "`$1 --version 2>&1 | grep GNU`" ]; then MAKE=$1; fi
-}
-
-# if $1 and $2 differ, exit with failure
-compare_output() {
-if ! [ "$1" = "$2" ]; then
-	echo \'$1\' should be \'$2\'
-	exit 1
-fi
-}
-
-# $1: object directory
-run_printall() {
-$MAKE CONFIG_USE_BLOBS=n CONFIG_CCACHE=n NOMKDIR=1 \
-	DOTCONFIG=$TMPCONFIG obj=$1 printall |        \
-	sed -e "s,^ *,," -e "s,^r.mstage-objs:=,,"    \
-	    -e "s,mainboard/[^/]*/[^/]*/,.../,g" |    \
-	tr " " "\n" | GREP_OPTIONS= grep "/static.*\.[co]" | sort | \
-	tr '\012\015' '  ' | sed -e "s,  *, ,g" -e "s, *$,,"
-}
-
-# find GNU make
-MAKE=
-search_make make
-[ -z $MAKE ] && search_make gmake
-[ -z $MAKE ] && search_make gnumake
-
-if [ "$MAKE" = "" ]; then
-	echo Could not identify GNU make
-	exit 1
-fi
-
-# prepare a config to use
-TMPOBJ=`mktemp .tmpobj.XXXXXX`
-rm $TMPOBJ
-mkdir -p ${TMPOBJ}
-TMPCONFIG=`mktemp .tmpconfig.XXXXXX`
-rm -f $TMPCONFIG
-$MAKE obj=$TMPOBJ DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
-
-# look up parent directory
-CURRENTDIR=`pwd -P`
-PARENTDIR=`dirname $CURRENTDIR`
-
-compare_output "`run_printall build`" "build/.../static.c build/.../static.c build/.../static.romstage.o"
-compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.romstage.o"
-compare_output "`run_printall /tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
-compare_output "`run_printall /../tmp`" "/tmp/.../static.c /tmp/.../static.c /tmp/.../static.romstage.o"
-
-rm -rf $TMPCONFIG $TMPOBJ
-



More information about the coreboot-gerrit mailing list