[coreboot-gerrit] New patch to review for coreboot: cc3abb6 storm: enable CBMEM console dump

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Apr 24 13:37:14 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9986

-gerrit

commit cc3abb62fb4ce1c2b6c3cdd4b227dbfe443d31dd
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Fri Apr 10 19:23:16 2015 -0700

    storm: enable CBMEM console dump
    
    This patch enables on storm the recently introduced 'console buffer
    dump on reboot' capability.
    
    BRANCH=none
    BUG=chromium:475347
    TEST=generated storm image with serial console disabled and both rw
        firmware A and B sections corrupted. Programmed the new image on
        an SP5 device and rebooted it. Observed the device dump cbmem
        console buffer to the serial output, terminating with
    
     VB2:vb2_fail() Need recovery, reason: 0x3 / 0xa
     Reboot requested (1008000a)
     Saving nvdata
     SF: Detected S25FL128S_256K with page size 10000, total 2000000
    
      and the LED ring started flashing indicating recovery mode.
    
    Change-Id: Idb50c86f59f393c783ccbc15de8f5564e2a1b38e
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0ec88001b152bb9f1d7268b83367131b004816f8
    Original-Change-Id: I9345eeb4d375f42fb1e4c617495b63b308ce51d9
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/265295
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/storm/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/storm/Kconfig b/src/mainboard/google/storm/Kconfig
index d2c011b..dfa00cc 100644
--- a/src/mainboard/google/storm/Kconfig
+++ b/src/mainboard/google/storm/Kconfig
@@ -25,7 +25,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select BOARD_ID_AUTO
 	select BOARD_ROMSIZE_KB_8192
 	select COMMON_CBFS_SPI_WRAPPER
-	select VBOOT_DISABLE_DEV_ON_RECOVERY
+	select CONSOLE_CBMEM_DUMP_TO_UART
 	select DRIVERS_I2C_WW_RING
 	select HAVE_HARD_RESET
 	select MAINBOARD_HAS_BOOTBLOCK_INIT
@@ -34,6 +34,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select SPI_FLASH
 	select SPI_FLASH_SPANSION
 	select SPI_FLASH_STMICRO
+	select VBOOT_DISABLE_DEV_ON_RECOVERY
 	select VIRTUAL_DEV_SWITCH
 	select WIPEOUT_SUPPORTED
 



More information about the coreboot-gerrit mailing list