[coreboot-gerrit] New patch to review for coreboot: 45219ad chromeos: Drop {developer, recovery}_mode_enabled

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Apr 22 13:21:15 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9951

-gerrit

commit 45219ad28b0d63b997e562f93caa052e49fcccf0
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Wed Apr 22 12:06:00 2015 +0200

    chromeos: Drop {developer,recovery}_mode_enabled
    
    They were already moved to src/lib/bootmode.c in
    commit 5687fc9 Declare recovery and developer modes outside ChromeOS
    
    Change-Id: Ia27a0c79baa364ce3779a8a699e9246d26d02ecb
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 src/vendorcode/google/chromeos/chromeos.c | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/src/vendorcode/google/chromeos/chromeos.c b/src/vendorcode/google/chromeos/chromeos.c
index 97c7e4f..08d9692 100644
--- a/src/vendorcode/google/chromeos/chromeos.c
+++ b/src/vendorcode/google/chromeos/chromeos.c
@@ -65,29 +65,6 @@ int vboot_skip_display_init(void)
 	return !(vbho->init_params.out_flags & VB_INIT_OUT_ENABLE_DISPLAY);
 }
 
-int developer_mode_enabled(void)
-{
-	return get_developer_mode_switch() || vboot_enable_developer();
-}
-
-int recovery_mode_enabled(void)
-{
-	/*
-	 * This is called in multiple places and has to detect
-	 * recovery mode triggered from the EC and via shared
-	 * recovery reason set with crossystem.
-	 *
-	 * If shared recovery reason is set:
-	 * - before VbInit then get_recovery_mode_from_vbnv() is true
-	 * - after VbInit then vboot_enable_recovery() is true
-	 *
-	 * Otherwise the mainboard handler for get_recovery_mode_switch()
-	 * will detect recovery mode initiated by the EC.
-	 */
-	return get_recovery_mode_switch() || get_recovery_mode_from_vbnv() ||
-		vboot_enable_recovery();
-}
-
 int __attribute__((weak)) clear_recovery_mode_switch(void)
 {
 	// Can be implemented by a mainboard



More information about the coreboot-gerrit mailing list