[coreboot-gerrit] New patch to review for coreboot: 4a192b7 Fix "dd: invalid number `0x800000'"

WANG Siyuan (wangsiyuanbuaa@gmail.com) gerrit at coreboot.org
Wed Apr 22 09:31:06 CEST 2015


WANG Siyuan (wangsiyuanbuaa at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9944

-gerrit

commit 4a192b7adb029b9a9f54782e9c78d210f3c4c1f1
Author: WANG Siyuan <wangsiyuanbuaa at gmail.com>
Date:   Wed Apr 22 15:22:00 2015 +0800

    Fix "dd: invalid number `0x800000'"
    
    dd doesn't recognise hex number. I have tested on AMD Olive Hill Plus.
    
    Change-Id: Ie0df3eb00fa2ba5d7bbb8218e24b864cbdd07c3a
    Signed-off-by: WANG Siyuan <SiYuan.Wang at amd.com>
    Signed-off-by: WANG Siyuan <wangsiyuanbuaa at gmail.com>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index 04e8085..b67f145 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -560,7 +560,7 @@ $(obj)/coreboot.rom: $(obj)/coreboot.pre $(objcbfs)/ramstage.elf $(CBFSTOOL) $(c
 	@printf "    CBFS       $(subst $(obj)/,,$(@))\n"
 # The full ROM may be larger than the CBFS part, so create an empty
 # file (filled with \377 = 0xff) and copy the CBFS image over it.
-	dd if=/dev/zero bs=$(CONFIG_ROM_SIZE) count=1 | tr '\000' '\377' > $@.tmp
+	dd if=/dev/zero bs=$(call _toint,$(CONFIG_ROM_SIZE)) count=1 2> /dev/null | tr '\000' '\377' > $@.tmp
 	dd if=$(obj)/coreboot.pre of=$@.tmp bs=8192 conv=notrunc 2> /dev/null
 	$(CBFSTOOL) $@.tmp add-stage -f $(objcbfs)/ramstage.elf -n $(CONFIG_CBFS_PREFIX)/ramstage -c $(CBFS_COMPRESS_FLAG)
 ifeq ($(CONFIG_PAYLOAD_NONE),y)



More information about the coreboot-gerrit mailing list