[coreboot-gerrit] Patch merged into coreboot/master: 243c614 lib: add base64 decoder

gerrit at coreboot.org gerrit at coreboot.org
Wed Apr 22 08:51:23 CEST 2015


the following patch was just integrated into master:
commit 243c614134cd29b764425b18e85aca7c6ea21ab7
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Fri Mar 27 16:08:04 2015 -0700

    lib: add base64 decoder
    
    It became necessary to decode base64 data retrieved from VPD and
    convert it into binary for inclusion in the device tree.
    
    The patch introduces the decoder function based on the description
    found in http://en.wikipedia.org/wiki/Base64.
    
    An open source implementation from http://base64.sourceforge.net was
    considered, in the end the only thing borrowed from it is the table to
    translate base64 ascii characters into numbers in 0..63 range.
    
    BRANCH=none
    BUG=chromium:450169
    
    TEST=created a test harness generating random contents of random size
         (in 8 to 32766 bytes range), then converting the contents into
         base64 using the Linux utility, and then converting it back to
         binary using this function and comparing the results.
    
         It succeeded 1700 iterations before it was stopped.
    
    Change-Id: I502f2c9494c99ba95ece37a7220c0c70c4755be2
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 6609f76e1559d3cdd402276055c99e0de7da27c8
    Original-Change-Id: I5ed68af3a4daead50c44ae0f0c63d836f4b66851
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/262945
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/9892
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9892 for details.

-gerrit



More information about the coreboot-gerrit mailing list