[coreboot-gerrit] New patch to review for coreboot: 620508a soc: select generic gpio lib on (almost) all non-x86 SOCs

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Apr 21 15:18:46 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9899

-gerrit

commit 620508a121a47d6ad24d7f3a7d49a8effff60213
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Thu Mar 26 15:58:41 2015 -0700

    soc: select generic gpio lib on (almost) all non-x86 SOCs
    
    BOARD_ID functionality is not what requires the GPIO lib,
    but it is the mainboard specific implementations that do.
    The option essentially says whether the SoC provides
    <soc/gpio.h> (with the interface required by the common
    GPIO code). Right now, x86 and Samsung's Exynos SOCs
    don't have support for this interface.
    
    So this should be selected by the SOC, not by
    BOARD_ID_SUPPORT.
    
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    
    BUG=none
    BRANCH=none
    TEST=emerge-storm coreboot still successfully compiled an image
    
    Change-Id: I0ce2bd7ce023f22791d31a6245833b61135504b3
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0dd4dea521372194eedf11b077d95fd3b15ad9f7
    Original-Change-Id: I3dea6c2fb42a23fcb9d384c3bbfa7fc8e217be2d
    Original-Reviewed-on: https://chromium-review.googlesource.com/262743
    Original-Reviewed-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Tested-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Queue: Stefan Reinauer <reinauer at chromium.org>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
---
 src/soc/broadcom/cygnus/Kconfig  | 1 +
 src/soc/imgtec/pistachio/Kconfig | 1 +
 src/soc/marvell/bg4cd/Kconfig    | 1 +
 src/soc/nvidia/tegra124/Kconfig  | 2 +-
 src/soc/nvidia/tegra132/Kconfig  | 1 +
 src/soc/qualcomm/ipq806x/Kconfig | 1 +
 src/soc/rockchip/rk3288/Kconfig  | 1 +
 7 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/soc/broadcom/cygnus/Kconfig b/src/soc/broadcom/cygnus/Kconfig
index 3e66688..468f2ef 100644
--- a/src/soc/broadcom/cygnus/Kconfig
+++ b/src/soc/broadcom/cygnus/Kconfig
@@ -34,6 +34,7 @@ config SOC_BROADCOM_CYGNUS
 	select HAVE_UART_SPECIAL
 	select HAS_PRECBMEM_TIMESTAMP_REGION
 	select RETURN_FROM_VERSTAGE
+	select GENERIC_GPIO_LIB
 
 if SOC_BROADCOM_CYGNUS
 
diff --git a/src/soc/imgtec/pistachio/Kconfig b/src/soc/imgtec/pistachio/Kconfig
index 9eb001d..423e988 100644
--- a/src/soc/imgtec/pistachio/Kconfig
+++ b/src/soc/imgtec/pistachio/Kconfig
@@ -27,6 +27,7 @@ config CPU_IMGTEC_PISTACHIO
 	select HAVE_UART_MEMORY_MAPPED
 	select HAVE_UART_SPECIAL
 	select SPI_ATOMIC_SEQUENCING
+	select GENERIC_GPIO_LIB
 	bool
 
 if CPU_IMGTEC_PISTACHIO
diff --git a/src/soc/marvell/bg4cd/Kconfig b/src/soc/marvell/bg4cd/Kconfig
index d7f8327..b1fabb7 100644
--- a/src/soc/marvell/bg4cd/Kconfig
+++ b/src/soc/marvell/bg4cd/Kconfig
@@ -30,6 +30,7 @@ config SOC_MARVELL_BG4CD
 	select EARLY_CONSOLE
 	select GENERIC_UDELAY
 	select HAVE_MONOTONIC_TIMER
+	select GENERIC_GPIO_LIB
 
 if SOC_MARVELL_BG4CD
 
diff --git a/src/soc/nvidia/tegra124/Kconfig b/src/soc/nvidia/tegra124/Kconfig
index b934f4e..9c83865 100644
--- a/src/soc/nvidia/tegra124/Kconfig
+++ b/src/soc/nvidia/tegra124/Kconfig
@@ -12,7 +12,7 @@ config SOC_NVIDIA_TEGRA124
 	select BOOTBLOCK_CONSOLE
 	select ARM_BOOTBLOCK_CUSTOM
 	select ARM_LPAE
-
+	select GENERIC_GPIO_LIB
 
 if SOC_NVIDIA_TEGRA124
 
diff --git a/src/soc/nvidia/tegra132/Kconfig b/src/soc/nvidia/tegra132/Kconfig
index 4c927a8..fc32102 100644
--- a/src/soc/nvidia/tegra132/Kconfig
+++ b/src/soc/nvidia/tegra132/Kconfig
@@ -17,6 +17,7 @@ config SOC_NVIDIA_TEGRA132
 	select DYNAMIC_CBMEM
 	select SMP
 	select ARCH_USE_SECURE_MONITOR
+	select GENERIC_GPIO_LIB
 
 if SOC_NVIDIA_TEGRA132
 
diff --git a/src/soc/qualcomm/ipq806x/Kconfig b/src/soc/qualcomm/ipq806x/Kconfig
index a18fc2e..5c03d52 100644
--- a/src/soc/qualcomm/ipq806x/Kconfig
+++ b/src/soc/qualcomm/ipq806x/Kconfig
@@ -10,6 +10,7 @@ config SOC_QC_IPQ806X
 	select DYNAMIC_CBMEM
 	select HAVE_UART_SPECIAL
 	select SPI_ATOMIC_SEQUENCING
+	select GENERIC_GPIO_LIB
 
 if SOC_QC_IPQ806X
 
diff --git a/src/soc/rockchip/rk3288/Kconfig b/src/soc/rockchip/rk3288/Kconfig
index 60d69f6..ed8001d 100644
--- a/src/soc/rockchip/rk3288/Kconfig
+++ b/src/soc/rockchip/rk3288/Kconfig
@@ -31,6 +31,7 @@ config SOC_ROCKCHIP_RK3288
 	select HAVE_UART_SPECIAL
 	select BOOTBLOCK_CONSOLE
 	select UNCOMPRESSED_RAMSTAGE
+	select GENERIC_GPIO_LIB
 
 if SOC_ROCKCHIP_RK3288
 



More information about the coreboot-gerrit mailing list