[coreboot-gerrit] Patch set updated for coreboot: 991f97f Makefile: Disable implicit rules

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Apr 21 11:19:03 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9865

-gerrit

commit 991f97fa2367d89dff6e921af4908847d08739c9
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Mar 13 11:05:07 2015 -0700

    Makefile: Disable implicit rules
    
    This patch disables implicit make rules (like %.o: %.c) from our build
    system, since we don't use them and they can cause unexpected results
    when there's a mistake in the Makefiles.
    
    BRANCH=None
    BUG=chromium:466469
    TEST=emerge-falco coreboot fails with only this patch and succeeds with
    this and the $(src-to-obj) fix.
    
    Change-Id: I7478adaddbbeaa2226fd941ffacfce2577ba59ba
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: c2543f25f7db61f93be96784eca3f4f65e3ffaa0
    Original-Change-Id: Ia6a91f040ad4ef556cf7912cd82a73173dfec8cb
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/259947
    Original-Reviewed-by: Mike Frysinger <vapier at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-by: Patrick Georgi <pgeorgi at chromium.org>
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index e5255f8..14e1598 100644
--- a/Makefile
+++ b/Makefile
@@ -74,6 +74,9 @@ ifneq ($(Q),)
 endif
 endif
 
+# Disable implicit/built-in rules to make Makefile errors fail fast.
+.SUFFIXES:
+
 HOSTCC := gcc
 HOSTCXX = g++
 HOSTCFLAGS := -g



More information about the coreboot-gerrit mailing list