[coreboot-gerrit] New patch to review for coreboot: 9c97510 google/storm: enable virtual development mode switch

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Apr 21 10:44:50 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9875

-gerrit

commit 9c975105a859d0b9c4c2f561ea39a0831fc9c7fb
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Thu Mar 19 21:22:31 2015 -0700

    google/storm: enable virtual development mode switch
    
    The whirlwind device is using a button instead of the switch to enable
    dev mode.
    
    BRANCH=storm
    BUG=chrome-os-partner:36059
    TEST=with the rest of the patches applied it is possible to enable and
         disable dev mode on Whirlwind and the mode persists over reboots.
    
    Change-Id: I6d31c8429ea0515bea2b7d707325d9092487048a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 495bd07e3a1d6c587a5f01efa2801d2c4e7edbe8
    Original-Change-Id: I8879833ca13074e8275393c3b98df06d56a5361d
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/261416
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
---
 src/mainboard/google/storm/Kconfig    | 1 +
 src/mainboard/google/storm/chromeos.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/storm/Kconfig b/src/mainboard/google/storm/Kconfig
index 0f7ede3..c20594a 100644
--- a/src/mainboard/google/storm/Kconfig
+++ b/src/mainboard/google/storm/Kconfig
@@ -32,6 +32,7 @@ config BOARD_SPECIFIC_OPTIONS
 	select SPI_FLASH
 	select SPI_FLASH_SPANSION
 	select SPI_FLASH_STMICRO
+	select VIRTUAL_DEV_SWITCH
 	select WIPEOUT_SUPPORTED
 
 config BOARD_VARIANT_AP148
diff --git a/src/mainboard/google/storm/chromeos.c b/src/mainboard/google/storm/chromeos.c
index 0448206..0076b3c 100644
--- a/src/mainboard/google/storm/chromeos.c
+++ b/src/mainboard/google/storm/chromeos.c
@@ -62,7 +62,7 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 
 int get_developer_mode_switch(void)
 {
-	return read_gpio(DEV_SW) ^ !DEV_POL;
+	return 0;
 }
 
 /*



More information about the coreboot-gerrit mailing list