[coreboot-gerrit] Patch set updated for coreboot: 9b69fc0 rockchip/rk3288: use bl_en instead lcd_bl to fill_lb_gpio
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Tue Apr 21 10:44:33 CEST 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9864
-gerrit
commit 9b69fc052d52cb0b746a4b3137a34e8ae5a7044c
Author: huang lin <hl at rock-chips.com>
Date: Thu Mar 12 19:29:12 2015 -0700
rockchip/rk3288: use bl_en instead lcd_bl to fill_lb_gpio
in depthcharge we will use "backlight" gpio which in lb_gpio table
to control backlight, we use lcd_bl before, but it will not meet
the backlight power sequence, so we change it to bl_en.
BUG=chrome-os-partner:37348
TEST=Boot from speedy, and backlight work well
BRANCH=None
Change-Id: I19e488c7d3f1fe5cb91f8a93fae6b848f58b36b7
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: cb594ce612e1cedeabced4531fbd954f3698da98
Original-Change-Id: Ib0dac7c48bce7d0b28ec287b32d8c5bad575893f
Original-Signed-off-by: huang lin <hl at rock-chips.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/259900
Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
src/mainboard/google/veyron_danger/board.h | 2 +-
src/mainboard/google/veyron_jerry/board.h | 2 +-
src/mainboard/google/veyron_jerry/mainboard.c | 8 ++++----
src/mainboard/google/veyron_mighty/board.h | 2 +-
src/mainboard/google/veyron_mighty/mainboard.c | 8 ++++----
src/mainboard/google/veyron_pinky/board.h | 2 +-
src/mainboard/google/veyron_pinky/mainboard.c | 8 ++++----
src/mainboard/google/veyron_speedy/board.h | 2 +-
src/mainboard/google/veyron_speedy/mainboard.c | 8 ++++----
9 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/src/mainboard/google/veyron_danger/board.h b/src/mainboard/google/veyron_danger/board.h
index 4d0e8be..10bcf45 100644
--- a/src/mainboard/google/veyron_danger/board.h
+++ b/src/mainboard/google/veyron_danger/board.h
@@ -23,7 +23,7 @@
#include <boardid.h>
#include <gpio.h>
-#define GPIO_BACKLIGHT GPIO(7, A, 3)
+#define GPIO_BACKLIGHT GPIO(7, A, 3)
#define GPIO_RESET GPIO(0, B, 5)
void setup_chromeos_gpios(void);
diff --git a/src/mainboard/google/veyron_jerry/board.h b/src/mainboard/google/veyron_jerry/board.h
index 2f8a341..bf00b1b 100644
--- a/src/mainboard/google/veyron_jerry/board.h
+++ b/src/mainboard/google/veyron_jerry/board.h
@@ -23,7 +23,7 @@
#include <boardid.h>
#include <gpio.h>
-#define GPIO_BACKLIGHT GPIO(7, A, 0)
+#define GPIO_BACKLIGHT GPIO(7, A, 2)
#define GPIO_RESET GPIO(0, B, 5)
void setup_chromeos_gpios(void);
diff --git a/src/mainboard/google/veyron_jerry/mainboard.c b/src/mainboard/google/veyron_jerry/mainboard.c
index 6fb3a8f..2b9ec66 100644
--- a/src/mainboard/google/veyron_jerry/mainboard.c
+++ b/src/mainboard/google/veyron_jerry/mainboard.c
@@ -151,17 +151,17 @@ void mainboard_power_on_backlight(void)
{
switch (board_id()) {
case 2:
- gpio_output(GPIO_BACKLIGHT, 0); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 0); /* BL_EN */
gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 1); /* BL_EN */
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
mdelay(20);
- gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
+ gpio_output(GPIO(7, A, 0), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
+ gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
break;
}
}
diff --git a/src/mainboard/google/veyron_mighty/board.h b/src/mainboard/google/veyron_mighty/board.h
index 2ca1a41..3231054 100644
--- a/src/mainboard/google/veyron_mighty/board.h
+++ b/src/mainboard/google/veyron_mighty/board.h
@@ -23,7 +23,7 @@
#include <boardid.h>
#include <gpio.h>
-#define GPIO_BACKLIGHT GPIO(7, A, 0)
+#define GPIO_BACKLIGHT GPIO(7, A, 2)
#define GPIO_RESET GPIO(0, B, 5)
void setup_chromeos_gpios(void);
diff --git a/src/mainboard/google/veyron_mighty/mainboard.c b/src/mainboard/google/veyron_mighty/mainboard.c
index 5c41754..09a9054 100644
--- a/src/mainboard/google/veyron_mighty/mainboard.c
+++ b/src/mainboard/google/veyron_mighty/mainboard.c
@@ -151,17 +151,17 @@ void mainboard_power_on_backlight(void)
{
switch (board_id()) {
case 0:
- gpio_output(GPIO_BACKLIGHT, 0); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 0); /* BL_EN */
gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 1); /* BL_EN */
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
mdelay(20);
- gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
+ gpio_output(GPIO(7, A, 0), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
+ gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
break;
}
}
diff --git a/src/mainboard/google/veyron_pinky/board.h b/src/mainboard/google/veyron_pinky/board.h
index 45590e7..72c1e0c 100644
--- a/src/mainboard/google/veyron_pinky/board.h
+++ b/src/mainboard/google/veyron_pinky/board.h
@@ -23,7 +23,7 @@
#include <boardid.h>
#include <gpio.h>
-#define GPIO_BACKLIGHT GPIO(7, A, 0)
+#define GPIO_BACKLIGHT GPIO(7, A, 2)
#define GPIO_RESET (board_id() > 0 ? GPIO(0, B, 5) : GPIO(0, B, 2))
void setup_chromeos_gpios(void);
diff --git a/src/mainboard/google/veyron_pinky/mainboard.c b/src/mainboard/google/veyron_pinky/mainboard.c
index ef14c2d..b57314a 100644
--- a/src/mainboard/google/veyron_pinky/mainboard.c
+++ b/src/mainboard/google/veyron_pinky/mainboard.c
@@ -197,17 +197,17 @@ void mainboard_power_on_backlight(void)
case 0:
case 1:
case 2:
- gpio_output(GPIO_BACKLIGHT, 0); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 0); /* BL_EN */
gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 1); /* BL_EN */
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
mdelay(20);
- gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
+ gpio_output(GPIO(7, A, 0), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
+ gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
break;
}
}
diff --git a/src/mainboard/google/veyron_speedy/board.h b/src/mainboard/google/veyron_speedy/board.h
index f98854e..9a21700 100644
--- a/src/mainboard/google/veyron_speedy/board.h
+++ b/src/mainboard/google/veyron_speedy/board.h
@@ -23,7 +23,7 @@
#include <boardid.h>
#include <gpio.h>
-#define GPIO_BACKLIGHT GPIO(7, A, 0)
+#define GPIO_BACKLIGHT GPIO(7, A, 2)
#define GPIO_RESET GPIO(0, B, 5)
void setup_chromeos_gpios(void);
diff --git a/src/mainboard/google/veyron_speedy/mainboard.c b/src/mainboard/google/veyron_speedy/mainboard.c
index 5c41754..09a9054 100644
--- a/src/mainboard/google/veyron_speedy/mainboard.c
+++ b/src/mainboard/google/veyron_speedy/mainboard.c
@@ -151,17 +151,17 @@ void mainboard_power_on_backlight(void)
{
switch (board_id()) {
case 0:
- gpio_output(GPIO_BACKLIGHT, 0); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 0); /* BL_EN */
gpio_output(GPIO(7, A, 2), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
+ gpio_output(GPIO(7, A, 0), 1); /* BL_EN */
break;
default:
gpio_output(GPIO(2, B, 4), 1); /* BL_PWR_EN */
mdelay(20);
- gpio_output(GPIO_BACKLIGHT, 1); /* LCD_BL */
+ gpio_output(GPIO(7, A, 0), 1); /* LCD_BL */
mdelay(10);
- gpio_output(GPIO(7, A, 2), 1); /* BL_EN */
+ gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
break;
}
}
More information about the coreboot-gerrit
mailing list