[coreboot-gerrit] Patch merged into coreboot/master: 9ff8f6f Unify byte order macros and clrsetbits

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 21 08:23:32 CEST 2015


the following patch was just integrated into master:
commit 9ff8f6f818d4e5a8aa0fe21cbfaba9ccd865bc7b
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Feb 23 14:31:09 2015 -0800

    Unify byte order macros and clrsetbits
    
    This patch removes quite a bit of code duplication between cpu_to_le32()
    and clrsetbits_le32() style macros on the different architectures. This
    also syncs those macros back up to the new write32(a, v) style IO
    accessor macros that are now used on ARM and ARM64.
    
    CQ-DEPEND=CL:254862
    BRANCH=none
    BUG=chromium:444723
    TEST=Compiled Cosmos, Daisy, Blaze, Falco, Pinky, Pit, Rambi, Ryu,
    Storm and Urara. Booted on Jerry. Tried to compare binary images...
    unfortunately something about the new macro notation makes the compiler
    evaluate it more efficiently (not recalculating the address between the
    read and the write), so this was of limited value.
    
    Change-Id: If8ab62912c952d68a67a0f71e82b038732cd1317
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: fd43bf446581bfb84bec4f2ebb56b5de95971c3b
    Original-Change-Id: I7d301b5bb5ac0db7f5ff39e3adc2b28a1f402a72
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/254866
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/9838
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9838 for details.

-gerrit



More information about the coreboot-gerrit mailing list