[coreboot-gerrit] Patch merged into coreboot/master: 24f9476 romstage_handoff: Fix for changing CBMEM structure

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit 24f94765311429d937befb4bebe1632eb683fd2c
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Feb 25 11:37:32 2015 -0800

    romstage_handoff: Fix for changing CBMEM structure
    
    Adding a new field to a CBMEM structure does not work if there are
    systems with older RO that do not have this new field as it means
    romstage did not prepare the field and ramstage is using it
    uninitialized.
    
    To deal with this instead of adding a new field split the existing
    s3_resume variable into bytes, using the first byte for the existing
    s3_resume variable (which is always just 0 or 1) and the second byte
    for the new varible, which will always be 0 for the old RO and can
    be set by new RO.
    
    BUG=chrome-os-partner:37108
    BRANCH=samus
    TEST=manual testing on samus:
    1) ensure that if vboot requests reboot after TPM setup that it still
    works and the reboot happens after reference code execution.
    2) ensure that if RO is older without this change that it does not
    cause a continuous reboot if newer ramstage is added
    3) test that suspend resume still works as expected
    
    Reviewed-on: https://chromium-review.googlesource.com/253550
    Reviewed-by: Alec Berg <alecaberg at chromium.org>
    Reviewed-by: Shawn N <shawnn at chromium.org>
    (cherry picked from commit 1ccb7ee5fc6980ca0f26fa52b385d2cc52f396c9)
    
    Change-Id: I6e206b4a3b33b8a31d102d64bd37d34657cf49ac
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: fe85678ee788ff939bc8c084829a1b04232c4c6c
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Change-Id: If69d0ff9cc3bf596eee8c3a8d6e04951820a26fe
    Original-Reviewed-on: https://chromium-review.googlesource.com/256114
    Original-Reviewed-by: Shawn N <shawnn at chromium.org>
    Reviewed-on: http://review.coreboot.org/9833
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9833 for details.

-gerrit