[coreboot-gerrit] New patch to review for coreboot: 23bd700 rk3288: disable rk808 DCDC_UV_ACT_REG restart converter function

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Apr 20 11:19:53 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9831

-gerrit

commit 23bd7006902ef035c1b97d41ead58317dc4d97bc
Author: huang lin <hl at rock-chips.com>
Date:   Fri Feb 27 19:35:04 2015 -0800

    rk3288: disable rk808 DCDC_UV_ACT_REG restart converter function
    
    if DCDC_UV_ACT_REG setted, when the buck voltage drop to 85%,
    rk808 will reset this buck, but now when the current consumption large,
    rk808 may miscarriage of justice this status, so we must disable this function
    
    BUG=chrome-os-partner:34834
    TEST=Boot from jerry, and do RUNIN test sucess
    BRANCH=None
    
    Change-Id: I08cef73b88d6c2722b389c632c7db29605f4545d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 858c8abc11a824fc3d991a39a49710243f4b1473
    Original-Change-Id: I46ebe332c576eebd3386b5042b146a8b57a5c194
    Original-Signed-off-by: huang lin <hl at rock-chips.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/254496
    Original-Commit-Queue: Julius Werner <jwerner at chromium.org>
    Original-Tested-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/soc/rockchip/rk3288/rk808.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/soc/rockchip/rk3288/rk808.c b/src/soc/rockchip/rk3288/rk808.c
index d375f46..b922d81 100644
--- a/src/soc/rockchip/rk3288/rk808.c
+++ b/src/soc/rockchip/rk3288/rk808.c
@@ -54,6 +54,7 @@
 #define RTC_CTRL_GET_TIME	(1 << 6)
 #define RTC_CTRL_RTC_READSEL	(1 << 7)
 
+#define DCDC_UV_ACT		0x28
 #define DCDC_ILMAX		0x90
 
 static int rk808_read(uint8_t reg, uint8_t *value)
@@ -134,6 +135,10 @@ void rk808_configure_buck(int buck, int millivolts)
 		die("Unknown buck index!");
 	}
 	rk808_clrsetbits(DCDC_ILMAX, 0, 3 << ((buck - 1) * 2));
+
+	/* undervoltage detection may be wrong, disable it */
+	rk808_clrsetbits(DCDC_UV_ACT, 1 << (buck - 1), 0);
+
 	rk808_clrsetbits(buck_reg, 0x3f, vsel);
 	rk808_clrsetbits(DCDC_EN, 0, 1 << (buck - 1));
 }



More information about the coreboot-gerrit mailing list