[coreboot-gerrit] New patch to review for coreboot: 9fd7bb6 Improve coreboot startup printouts

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Apr 20 10:59:42 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9827

-gerrit

commit 9fd7bb61622075f4b70ef8f26357d49d62b31fb1
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Thu Feb 26 18:20:53 2015 -0800

    Improve coreboot startup printouts
    
    Add the absolute offset value to the CBFS log, to make it easier to
    understand which particular CBFS section the file is loaded from.
    
    BRANCH=storm
    BUG=none
    TEST=rebooted a Whirlwind device, observed an empty line before the
         ramstage section of the log and absolute offsets reported by
         CBFS.
    
    Change-Id: Ifcb79ab386629446b98625a5416dfa5850a105f6
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: ecc4d1df7c51a263230c45ecac5981d53bdd44b1
    Original-Change-Id: I5cc727127374d6e55b8ff6f45b250ef97125a8ec
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/255120
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/lib/cbfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 84638da..88a292f 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -88,8 +88,8 @@ static int cbfs_load_prog_stage_by_offset(struct cbfs_media *media,
 		return -1;
 	}
 
-	LOG("loading stage @ 0x%llx (%d bytes), entry @ 0x%llx\n",
-	    stage.load, stage.memlen, stage.entry);
+	LOG("loading stage from %#zx @ 0x%llx (%d bytes), entry @ 0x%llx\n",
+	    offset, stage.load, stage.memlen, stage.entry);
 
 	/* Stages rely the below clearing so that the bss is initialized. */
 	memset((void *)(uintptr_t)stage.load, 0, stage.memlen);



More information about the coreboot-gerrit mailing list