[coreboot-gerrit] Patch merged into coreboot/master: cdf92ea rk3288: Disable ramstage compression by default

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 20 10:19:58 CEST 2015


the following patch was just integrated into master:
commit cdf92eacd5d2f85de473778cc1ebf35c2468a7f2
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Dec 9 12:18:00 2014 -0800

    rk3288: Disable ramstage compression by default
    
    The ramstage is loaded from romstage, so the LZMA scratchpad buffer used
    to decompress it is part of the romstage BSS in SRAM. On RK3288, SRAM
    cannot be cached which makes the decompression so slow that it's faster
    to just load an uncompressed image from SPI. Disable ramstage
    compression on this SoC to account for that.
    
    [pg: implementation avoids restructuring all of Kconfig]
    
    BRANCH=None
    BUG=None
    TEST=Built for Pinky and Falco, confirmed that the former didn't have
    COMPRESS_RAMSTAGE in its .config and the latter still did. Measured a
    speed-up of about 35ms on Pinky. (For some weird reason, the
    decompression of the payload also takes way longer than on other
    platforms, although not as long as the ramstage. I have no explanation
    for that and can't really think of a good way to figure it out... maybe
    the Cortex-A12 is just terrible at some operation that LZMA uses a lot?)
    
    Change-Id: I9f67f7537696ec09496483b16b59a8b73f4cb11b
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/234192
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Reviewed-on: http://review.coreboot.org/9792
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9792 for details.

-gerrit



More information about the coreboot-gerrit mailing list