[coreboot-gerrit] Patch merged into coreboot/master: 7c25640 ipq806x: initialize UART even when console is not enabled

gerrit at coreboot.org gerrit at coreboot.org
Sat Apr 18 08:54:16 CEST 2015


the following patch was just integrated into master:
commit 7c256405c35a0609dc03441f3fc698d9d578a3d6
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Jan 13 13:07:48 2015 -0800

    ipq806x: initialize UART even when console is not enabled
    
    The ipq806x UART is based on the same universal serial port which can
    be also configured as i2c or SPI. Configuring it is not a trivial
    task, so in case the kernel wants to use earlyprintk() the port needs
    to be configured by the firmware.
    
    Invoking uart_init() when the console is not enabled causes include
    file collisions, which would require changes to more than 100 files.
    Leaving this to another day, rearranging the ipq806x driver to be able
    to invoke UART initialization function even when serial console is not
    configured.
    
    Also add a check to avoid initialization if UART has been already
    set up.
    
    BRANCH=storm
    BUG=chrome-os-partner:35364
    TEST=verified that storm console is still fully operational when
         enabled, and that the kernel boots fine to the serial console
         login prompt even if the firmware console is disabled.
    
    Change-Id: Ibbbab875449f2ac2f0d6c504c18faf0da8251ffa
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: c512d6c1d0c0868137d1213ea84cd4bca58872db
    Original-Change-Id: I421acba3edf398d960b5058f15d1abb80ebc7660
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/240516
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/9794
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9794 for details.

-gerrit



More information about the coreboot-gerrit mailing list