[coreboot-gerrit] Patch merged into coreboot/master: b67b715 ipq806x: uart: replace hardware accessors

gerrit at coreboot.org gerrit at coreboot.org
Sat Apr 18 08:53:34 CEST 2015


the following patch was just integrated into master:
commit b67b7150fc38618f5cd6407cf86def9ad8b5e25b
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Jan 13 12:46:57 2015 -0800

    ipq806x: uart: replace hardware accessors
    
    Originally ported QCA UART driver used hardware accessor macros where
    both address and data were represented by 32 bit integers. Coreboot
    uses macros where addresses are represented by pointers, this make the
    code more robust, as accidental swap between address and data does not
    go unnoticed.
    
    This patch converts ipq806x UART driver to use coreboot accessors. It
    relies on gcc void pointer arithmetic considering objects pointed at
    by void pointers to be one byte in size. Also replacing spaces with
    hard tabs where appropriate.
    
    BRANCH=storm
    BUG=chrome-os-partner:34790
    TEST=new code still boots fine on Storm with console output present.
    
    Change-Id: I3ded9c338ff241bb1d839994f7296756aad8772d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 10616351704ebbcfcf25793ae974b256bc5bd6b0
    Original-Change-Id: Ie15e09f9f3ea10a8566b6845219c2e09fed39218
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/240514
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Trevor Bourget <tbourget at codeaurora.org>
    Reviewed-on: http://review.coreboot.org/9793
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9793 for details.

-gerrit



More information about the coreboot-gerrit mailing list