[coreboot-gerrit] New patch to review for coreboot: ceb9e95 libpayload udc: Clear bit when it needs clearing

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Apr 17 13:16:13 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9786

-gerrit

commit ceb9e9581201ef5cc316378f0cc9322b85b6b369
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Tue Mar 10 12:45:28 2015 +0100

    libpayload udc: Clear bit when it needs clearing
    
    Trivial copy & paste error, likely with no visible effect so far.
    
    BRANCH=none
    BUG=none
    TEST=none
    
    Change-Id: Ieaf5e770ab7a8474e407012d2c11a15c46ab357d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 90f8971500c95456ae70c6f4219b1ff9aff1c0b0
    Original-Change-Id: I973573efd0effc9e0173d2b259ce577b6de38de4
    Original-Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/258060
    Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
 payloads/libpayload/drivers/udc/chipidea.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/udc/chipidea.c b/payloads/libpayload/drivers/udc/chipidea.c
index 850d0c0..87c3076 100644
--- a/payloads/libpayload/drivers/udc/chipidea.c
+++ b/payloads/libpayload/drivers/udc/chipidea.c
@@ -433,7 +433,7 @@ static void chipidea_stall(struct usbdev_ctrl *this,
 			clrbits_le32(ctrl, 1 << 16);
 		} else {
 			setbits_le32(ctrl, 1 << 6);
-			setbits_le32(ctrl, 1 << 0);
+			clrbits_le32(ctrl, 1 << 0);
 		}
 	}
 	this->ep_halted[ep][in_dir] = set;



More information about the coreboot-gerrit mailing list