[coreboot-gerrit] Patch merged into coreboot/master: f97b88b Makefile: Fix dependency tracking for ramstage objects

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 17 09:55:41 CEST 2015


the following patch was just integrated into master:
commit f97b88bee8f65e3d7d73a5eede632d027b6a08a6
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Dec 5 12:32:09 2014 -0800

    Makefile: Fix dependency tracking for ramstage objects
    
    Dependency tracking in incremental builds is currently broken for the
    ramstage, due to the intermediate linking step into one ramstage.o file
    per directory. The original xxx.ramstage.o files are removed from
    ramstage-objs, so they don't end up in allobjs and won't get translated
    into DEPENDENCIES. This patch explicitly adds them to DEPENDENCIES
    beforehand to resolve the issue.
    
    BRANCH=None
    BUG=None
    TEST=Built, ran 'touch src/include/cbmem.h' and built again
    incrementally. Confirmed that objects dependent on the modified header
    such as timestamp.ramstage.o get rebuilt correctly.
    
    Change-Id: I3ba411e4073b38e038445aadceeccfe6c09670c8
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 9c57d6a8421a109ee3e87567c9add579f9ae761e
    Original-Change-Id: Ife529ad8f5c011456c1e0c380356f1b1bb5047cb
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/233571
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/9745
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9745 for details.

-gerrit



More information about the coreboot-gerrit mailing list