[coreboot-gerrit] Patch merged into coreboot/master: f9b49e8 Add delay before reading GPIOs in gpio_base2_value()

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 17 09:21:05 CEST 2015


the following patch was just integrated into master:
commit f9b49e8782efb7628984e1f3c3abc1ef7a58b84b
Author: David Hendricks <dhendrix at chromium.org>
Date:   Wed Jan 14 20:41:30 2015 -0800

    Add delay before reading GPIOs in gpio_base2_value()
    
    This adds a 10us delay in between (re-)configuring and reading
    GPIOs in gpio_base2_value() to give the values stored some time
    to update.
    
    As far as I know this hasn't bitten us since the function was
    added, but adding a short delay here seems like the right thing
    to do.
    
    BUG=none
    BRANCH=none
    TEST=built and booted on Brain
    
    Change-Id: I869cf375680435ad87729f93d29a623bdf09dfbc
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 2484900fc9ceba87220a293de8ef20c3b9b20cfd
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Change-Id: I79616a09d8d2ce4e416ffc94e35798dd25a6250d
    Original-Reviewed-on: https://chromium-review.googlesource.com/240854
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: http://review.coreboot.org/9725
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9725 for details.

-gerrit



More information about the coreboot-gerrit mailing list