[coreboot-gerrit] Patch merged into coreboot/master: 90d0acb as3277: Fix month-off-by-one error for RTC driver

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 17 09:20:56 CEST 2015


the following patch was just integrated into master:
commit 90d0acbe9a32f2b01e1e7a2d973bf23dd1998f13
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Dec 30 18:38:06 2014 -0800

    as3277: Fix month-off-by-one error for RTC driver
    
    The AS3277 RTC code seems to closely follow the corresponding Linux
    driver. Unfortunately, while coreboot (and even other parts of Linux,
    like mktime()) directly follows the standard IBM PC RTC time
    representation (except for the BCD part), Linux' struct rtc_time decided
    to use 0-based (instead of 1-based) months instead.
    
    This patch removes the faulty month offset that was copied into our
    driver so that we will generate correct timestamps again.
    
    BRANCH=nyan
    BUG=chrome-os-partner:34108
    TEST=firmware_EventLog (pre-release version) gets further than before
    (and then craps up on unrelated problems with suspend/resume events).
    
    Change-Id: Ica221a8bcfd7c1c6cd7ba382d760b586d511e3a3
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 5b55c3f5bbecc776a71338256b910aecccac1e04
    Original-Change-Id: I163fa4778ec534cd9e6f92a6b6dc55e9871a6a82
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/238122
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/9723
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9723 for details.

-gerrit



More information about the coreboot-gerrit mailing list