[coreboot-gerrit] New patch to review for coreboot: ce574a7 x86: fix hung ramstage

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Wed Apr 15 00:13:34 CEST 2015


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9695

-gerrit

commit ce574a78639b55f6d6c02dc45458305aaae54b3b
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Apr 14 17:11:40 2015 -0500

    x86: fix hung ramstage
    
    In commit a43db197 STACK_SIZE was being unconditionally set to 0x0
    when parsing MIPS' and ARM's Kconfig files. This caused x86 to hang
    in romstage since the stack was 0. Badness all around.
    
    Change-Id: Id75e830c6eea31617f27873d5c68fd5ff496d318
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/Kconfig           | 3 +++
 src/arch/arm/Kconfig  | 5 -----
 src/arch/mips/Kconfig | 5 -----
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index 8a5d905..7ecd6de 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -320,6 +320,9 @@ config HEAP_SIZE
 config STACK_SIZE
 	hex
 	default 0x1000
+# Mark SMP stack size as 0 since we keep using SRAM stack throughout ramstage.
+	default 0x0 if ARCH_MIPS
+	default 0x0 if ARCH_ARM
 
 config MAX_CPUS
 	int
diff --git a/src/arch/arm/Kconfig b/src/arch/arm/Kconfig
index 6bef91c..2499d2d 100644
--- a/src/arch/arm/Kconfig
+++ b/src/arch/arm/Kconfig
@@ -31,8 +31,3 @@ config ARM_BOOTBLOCK_CUSTOM
 config ARM_LPAE
 	bool
 	default n
-
-# Mark SMP stack size as 0 since we keep using SRAM stack throughout ramstage.
-config STACK_SIZE
-	hex
-	default 0x0
diff --git a/src/arch/mips/Kconfig b/src/arch/mips/Kconfig
index 71e5dc8..10349f2 100644
--- a/src/arch/mips/Kconfig
+++ b/src/arch/mips/Kconfig
@@ -39,8 +39,3 @@ config ARCH_ROMSTAGE_MIPS
 config ARCH_RAMSTAGE_MIPS
 	bool
 	default n
-
-# Mark SMP stack size as 0 since we keep using SRAM stack throughout ramstage.
-config STACK_SIZE
-	hex
-	default 0x0



More information about the coreboot-gerrit mailing list