[coreboot-gerrit] Patch set updated for coreboot: eea9b94 libpayload: avoid hanging on make junit.xml

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Apr 14 10:29:45 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9676

-gerrit

commit eea9b945ec5fe12f10fe300ffefafd557a57fe08
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Tue Apr 14 10:27:03 2015 +0200

    libpayload: avoid hanging on make junit.xml
    
    make oldconfig doesn't like 'y' as response to a choice item
    such as the architecture list. An empty response, however, is
    acceptable, so use that.
    
    Change-Id: Ic3164dd3f40e4a7f5d91e3a7008893655cd69ac2
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
 payloads/libpayload/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/Makefile.inc b/payloads/libpayload/Makefile.inc
index 8bf4ef5..ed2e71f 100644
--- a/payloads/libpayload/Makefile.inc
+++ b/payloads/libpayload/Makefile.inc
@@ -125,7 +125,7 @@ junit.xml:
 	echo '<?xml version="1.0" encoding="utf-8"?><testsuite>' > $@.tmp
 	for i in $(filter-out %.old,$(wildcard configs/*)); do \
 		$(MAKE) clean; \
-		yes | $(MAKE) oldconfig DOTCONFIG=$$i V=$(V) Q=$(Q) 2>/dev/null >/dev/null; \
+		yes "" | $(MAKE) oldconfig DOTCONFIG=$$i V=$(V) Q=$(Q) 2>/dev/null >/dev/null; \
 		echo "<testcase classname='libpayload' name='$$i'>" >> $@.tmp; \
 		$(MAKE) V=$(V) Q=$(Q) CONFIG_CCACHE=$(CONFIG_CCACHE) DOTCONFIG=$$i >> $@.tmp.2 2>&1 && type="system-out" || type="failure"; \
 		if [ $$type = "failure" ]; then \



More information about the coreboot-gerrit mailing list