[coreboot-gerrit] Patch merged into coreboot/master: a43db19 arm: Fix checkstack() to use correct stack size

[gerrit at coreboot.org]

the following patch was just integrated into master:
commit a43db197f3bc8c19aa99276dbcd5b260ebc41803
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Dec 15 18:19:03 2014 -0800

    arm: Fix checkstack() to use correct stack size
    
    checkstack() runs at the end of ramstage to warn about stack overflows,
    and it assumes that CONFIG_STACK_SIZE is always the size of the stack to
    check. This is only true for systems that bring up multiprocessing in
    ramstage and assign a separate stack for each core, like x86 and ARM64.
    Other architectures like ARM and MIPS (for now) don't touch secondary
    CPUs at all and currently don't look like they'll ever need to, so they
    generally stay on the same (SRAM-based) stack they have been on since
    their bootblock.
    
    This patch tries to model that difference by making these architectures
    explicitly set CONFIG_STACK_SIZE to zero, and using that as a cue to
    assume the whole (_estack - _stack) area in checkstack() instead. Also
    adds a BUG() to the stack overflow check, since that is currently just
    as non-fatal as the BIOS_ERR message (despite the incorrect "SYSTEM
    HALTED" output) but a little more easy to spot. Such a serious failure
    should not drown out in all the normal random pieces of lower case boot
    spam (also, I was intending to eventually have a look at assert() and
    BUG() to hopefully make them a little more useful/noticeable if I ever
    find the time for it).
    
    BRANCH=None
    BUG=None
    TEST=Booted Pinky, noticed it no longer complains about stack overflows.
    Built Falco, Ryu and Urara.
    
    Change-Id: I6826e0ec24201d4d83c5929b281828917bc9abf4
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 54229a725e8907b84a105c04ecea33b8f9b91dd4
    Original-Change-Id: I49f70bb7ad192bd1c48e077802085dc5ecbfd58b
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/235894
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/9610
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9610 for details.

-gerrit