[coreboot-gerrit] New patch to review for coreboot: 18e96ba urara: remove call to printk before UART is initialized

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Apr 14 03:03:09 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9668

-gerrit

commit 18e96bad429735a717e22128f1fd18dfb953fa34
Author: Ionela Voinescu <ionela.voinescu at imgtec.com>
Date:   Tue Jan 27 13:01:43 2015 +0000

    urara: remove call to printk before UART is initialized
    
    BUG=chrome-os-partner:31438
    TEST=tested in Pistachio bring up board; previous delay
         at the beginning of bootblock is fixed.
    BRANCH=none
    
    Change-Id: I30335677c96bfd651bc49e36b562c48588009d67
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: 3d1eb117644af1323dd940e0a82a2ef44025d5b9
    Original-Change-Id: I122df1f985163836bb2ddd027ef6ab2ce265d5dd
    Original-Signed-off-by: Ionela Voinescu <ionela.voinescu at imgtec.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/243223
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
---
 src/mainboard/google/urara/bootblock.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/mainboard/google/urara/bootblock.c b/src/mainboard/google/urara/bootblock.c
index 56177da..6d90d59 100644
--- a/src/mainboard/google/urara/bootblock.c
+++ b/src/mainboard/google/urara/bootblock.c
@@ -22,7 +22,6 @@
 #include <arch/io.h>
 #include <stdint.h>
 #include <soc/clocks.h>
-#include <console/console.h>
 
 #define GPIO_BIT_EN_ADDR(bank)		(0xB8101C00 + 0x200 + (0x24 * (bank)))
 
@@ -134,8 +133,6 @@ static void bootblock_mainboard_init(void)
 	if (!init_clocks()) {
 		/* Disable GPIO on the peripheral lines */
 		uart1_mfio_setup();
-		printk(BIOS_INFO, "Urara board: UART initialized!\n");
-
 		spim1_mfio_setup();
 	}
 



More information about the coreboot-gerrit mailing list