[coreboot-gerrit] New patch to review for coreboot: 3166ad0 brain: remove sdmmc_power_off() in romstage

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Tue Apr 14 02:41:20 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9648

-gerrit

commit 3166ad079b0c5af38a8c04c0930dee0da06a45fd
Author: David Hendricks <dhendrix at chromium.org>
Date:   Fri Jan 16 17:42:08 2015 -0800

    brain: remove sdmmc_power_off() in romstage
    
    LDO4 and LDO5 are not turned on with the boot0 and boot1 RK808
    strappings that we use on Brain.
    
    BUG=none
    BRANCH=none
    TEST=built and booted on brain
    
    Change-Id: I00393ca54958d9fff926606405edcd84901e4048
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: c4c1862585fd058a8a9c8237c701b3bbf3b8aa83
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Change-Id: I846ef9d67a780cc07414d545524b9ec0b8490cf1
    Original-Reviewed-on: https://chromium-review.googlesource.com/241734
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/mainboard/google/veyron_brain/romstage.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/mainboard/google/veyron_brain/romstage.c b/src/mainboard/google/veyron_brain/romstage.c
index b073c34..e41f2eb 100644
--- a/src/mainboard/google/veyron_brain/romstage.c
+++ b/src/mainboard/google/veyron_brain/romstage.c
@@ -77,12 +77,6 @@ static void configure_l2ctlr(void)
 	write_l2ctlr(l2ctlr);
 }
 
-static void sdmmc_power_off(void)
-{
-	rk808_configure_ldo(4, 0); /* VCCIO_SD */
-	rk808_configure_ldo(5, 0); /* VCC33_SD */
-}
-
 void main(void)
 {
 	void *entry;
@@ -93,9 +87,6 @@ void main(void)
 	configure_l2ctlr();
 	tsadc_init();
 
-	/* Need to power cycle SD card to ensure it is properly reset. */
-	sdmmc_power_off();
-
 	/* vdd_log 1200mv is enough for ddr run 666Mhz */
 	regulate_vdd_log(1200);
 	timestamp_add_now(TS_BEFORE_INITRAM);



More information about the coreboot-gerrit mailing list