[coreboot-gerrit] New patch to review for coreboot: 30b4bff google/rush_ryu: audio: Setup clocks for AHUB, I2S1, codec, etc.

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9523

-gerrit

commit 30b4bffbe634373db7ac60ea14323f1666c50923
Author: Tom Warren <twarren at nvidia.com>
Date:   Mon Nov 17 16:09:38 2014 -0700

    google/rush_ryu: audio: Setup clocks for AHUB, I2S1, codec, etc.
    
    The Ryu RT5677 audio codec uses EXTPERIPH1 clock (12MHz)
    for MCLK1, I2S1 for input. AHUB needs all of its child
    peripherals taken out of reset and enabled, too.
    
    This just sets up the audio clocks. More work still to
    be done in the codec driver, and some kind of stub needs
    to be created/hacked to set up the AD4567 speaker amp
    regs for mono output on P1.
    
    BUG=chrome-os-partner:32582
    BRANCH=none
    TEST=Dumped clock regs and saw correct values
    
    Change-Id: Ifb6551f1e09b38f440f3bb7c759b5e6c0b9e4e44
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 48f989a0291044f5fb4340cc89546325d819d82f
    Original-Change-Id: I6c9e760ac39def92a6054d673f781facdbfd70a2
    Original-Signed-off-by: Tom Warren <twarren at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/229993
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/rush_ryu/mainboard.c | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/rush_ryu/mainboard.c b/src/mainboard/google/rush_ryu/mainboard.c
index 2b71c98..81c15b4 100644
--- a/src/mainboard/google/rush_ryu/mainboard.c
+++ b/src/mainboard/google/rush_ryu/mainboard.c
@@ -57,8 +57,8 @@ static const struct pad_config mmcpads[] = {
 
 static const struct pad_config audio_codec_pads[] = {
 	/* H1 is CODEC_RST_L and R2(ROW2) is AUDIO_ENABLE */
-        PAD_CFG_GPIO_OUT1(GPIO_PH1, PINMUX_PULL_DOWN),
-        PAD_CFG_GPIO_OUT1(KB_ROW2, PINMUX_PULL_DOWN),
+	PAD_CFG_GPIO_OUT1(GPIO_PH1, PINMUX_PULL_DOWN),
+	PAD_CFG_GPIO_OUT1(KB_ROW2, PINMUX_PULL_DOWN),
 };
 
 static const struct funit_cfg funits[] = {
@@ -186,6 +186,30 @@ static int configure_display_blocks(void)
 	return 0;
 }
 
+/* Audio init: clocks and enables/resets */
+static void setup_audio(void)
+{
+	/* External peripheral 1: audio codec (RT5677) using 12MHz CLK1 */
+	clock_configure_source(extperiph1, CLK_M, 12000);
+
+	/*
+	* We need 1.5MHz for I2S1. So, we use CLK_M. CLK_DIVIDER macro
+	* returns a divisor (0xe) a little bit off from the ideal value (0xd),
+	* but it's good enough for beeps.
+	*/
+	clock_configure_source(i2s1, CLK_M, 1500);
+
+	clock_external_output(1);	/* For external RT5677 audio codec. */
+
+	/*
+	* Confirmed by NVIDIA hardware team, we need to take ALL audio devices
+	* connected to AHUB (AUDIO, APBIF, I2S, DAM, AMX, ADX, SPDIF, AFC) out
+	* of reset and clock-enabled, otherwise reading AHUB devices (in our
+	* case, I2S/APBIF/AUDIO<XBAR>) will hang.
+	*/
+	clock_enable_audio();
+}
+
 static void mainboard_init(device_t dev)
 {
 	soc_configure_funits(funits, ARRAY_SIZE(funits));
@@ -193,6 +217,9 @@ static void mainboard_init(device_t dev)
 	/* I2C6 bus (audio, etc.) */
 	soc_configure_i2c6pad();
 	i2c_init(I2C6_BUS);
+
+	setup_audio();
+
 	elog_init();
 	elog_add_boot_reason();