[coreboot-gerrit] Patch merged into coreboot/master: f44319c util/bimgtool: Add verification mode

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 10 12:03:37 CEST 2015


the following patch was just integrated into master:
commit f44319c12d4dc228cc193233b422c4afafe480bd
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Nov 4 16:17:33 2014 -0800

    util/bimgtool: Add verification mode
    
    When only one argument is passed on the command line, consider this
    argument the name of the BIMG formatted file, and verify its
    integrity.
    
    Update the help/usage text to match new behavior.
    
    BRANCH=none
    BUG=none
    
    TEST=when the corrupted coreboot BIMG image is passed as the only
         argument, this utility reports the problem. With the build fixed,
         the check passes without errors (the second invocation below).
    
    $ build/util/bimgtool/bimgtool /build/urara/firmware/coreboot.rom.serial
    Data header CRC mismatch at 0
    $ build/util/bimgtool/bimgtool /build/urara/firmware/coreboot.rom.serial
    $
    
    Change-Id: I9f0672caa38e3d27917471fc5137ede4ca466e9a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 3e631c311dbf2fb04714e437f95c41629155527f
    Original-Change-Id: Ie56f87f99838891d8e341d7989c614efbcabe0cd
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/227522
    Original-Reviewed-by: Zdenko Pulitika <zdenko.pulitika at imgtec.com>
    Original-Tested-by: Ionela Voinescu <ionela.voinescu at imgtec.com>
    Reviewed-on: http://review.coreboot.org/9452
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9452 for details.

-gerrit



More information about the coreboot-gerrit mailing list