[coreboot-gerrit] Patch merged into coreboot/master: 7a89d85 rk3288: Adjust CBFS header and ROM offsets

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 10 11:59:21 CEST 2015


the following patch was just integrated into master:
commit 7a89d8550ddd3546e15a089da94436606bb75cc0
Author: Julius Werner <jwerner at chromium.org>
Date:   Thu Nov 6 17:32:58 2014 -0800

    rk3288: Adjust CBFS header and ROM offsets
    
    Our CBFS header offset on rk3288 was very low and overlapped with the
    end of the bootblock on recent Pinky builds. This can create all kinds
    of fun effects like BSS variables suddenly being initialized to
    something else than zero, in an effect that jumps somewhere else for
    every slightest code size change.
    
    This patch moves the CBFS header offset up a bit and the CBFS ROM offset
    down (because there's really no point in leaving such a large gap). This
    resolves our immediate booting problems, and I'll also start on a patch
    to add further checks somewhere that catch these overlaps in the future.
    
    BRANCH=None
    BUG=None
    TEST=Created a Pinky image from the exact same commit version as the
    official 6443.0.0 build, with a KERNELREVISION string of the exact same
    length as the builder (which for some arcane reason is different than
    running emerge locally, shifting the whole bootblock around with it).
    Confirmed that I saw the same "Not enough room for another
    sub-pagetable!" hang, and that this patch fixes it.
    
    Change-Id: I9e59a282b3cd0af3b0d224d64c10b7c4d312ad02
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 1a142cd2c51c6f51a1597c21ad513feb151e0938
    Original-Change-Id: I8be5b7b7e87021cc1b3a91d336e8d233546ee188
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/228326
    Original-Reviewed-by: Gediminas Ramanauskas <gedis at chromium.org>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/9410
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9410 for details.

-gerrit



More information about the coreboot-gerrit mailing list