[coreboot-gerrit] Patch merged into coreboot/master: eaa9c45 gpio: Extend common GPIO header, simplify function names

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 10 11:57:35 CEST 2015


the following patch was just integrated into master:
commit eaa9c4596b083ee1d1a48c5e7632abdb5b7e5297
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Sep 24 15:40:49 2014 -0700

    gpio: Extend common GPIO header, simplify function names
    
    We've had gpiolib.h which defines a few common GPIO access functions for
    a while, but it wasn't really complete. This patch adds the missing
    gpio_output() function, and also renames the unwieldy
    gpio_get_in_value() and gpio_set_out_value() to the much easier to
    handle gpio_get() and gpio_set(). The header is renamed to the simpler
    gpio.h while we're at it (there was never really anything "lib" about
    it, and it was presumably just chosen due to the IPQ806x include/
    conflict problem that is now resolved).
    
    It also moves the definition of gpio_t into SoC-specific code, so that
    different implementations are free to encode their platform-specific
    GPIO parameters in those 4 bytes in the most convenient way (such as the
    rk3288 with a bitfield struct). Every SoC intending to use this common
    API should supply a <soc/gpio.h> that typedefs gpio_t to a type at most
    4 bytes in length. Files accessing the API only need to include <gpio.h>
    which may pull in additional things (like a gpio_t creation macro) from
    <soc/gpio.h> on its own.
    
    For now the API is still only used on non-x86 SoCs. Whether it makes
    sense to expand it to x86 as well should be separately evaluated at a
    later point (by someone who understands those systems better). Also,
    Exynos retains its old, incompatible GPIO API even though it would be a
    prime candidate, because it's currently just not worth the effort.
    
    BUG=None
    TEST=Compiled on Daisy, Peach_Pit, Nyan_Blaze, Rush_Ryu, Storm and
    Veyron_Pinky.
    
    Change-Id: Ieee77373c2bd13d07ece26fa7f8b08be324842fe
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 9e04902ada56b929e3829f2c3b4aeb618682096e
    Original-Change-Id: I6c1e7d1e154d9b02288aabedb397e21e1aadfa15
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/220975
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/9400
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9400 for details.

-gerrit



More information about the coreboot-gerrit mailing list