[coreboot-gerrit] New patch to review for coreboot: 7bbe70c broadwell: Skip steps when disabling PCIe port

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Apr 10 00:57:04 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9489

-gerrit

commit 7bbe70c94c46df55d60432fab42d27f486156b1e
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Jan 14 17:30:20 2015 -0800

    broadwell: Skip steps when disabling PCIe port
    
    When disabling PCIe ports skip steps if no card is detected.
    This prevents the loop from timing out on each empty slot.
    
    BUG=chrome-os-partner:31424
    BRANCH=broadwell
    TEST=build and boot on samus, check that this code is
    no longer timing out when disabling PCIe ports
    
    Change-Id: I84ee0e0e325784b3af06abe70420c07cf6e13ed2
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: 4d759e2350dd00ceb7df196ac7008729dc1e4cef
    Original-Change-Id: Idd88f0f1191a5465a0d8dcca07b5c3a5c5ca8855
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/240851
    Original-Reviewed-by: Wenkai Du <wenkai.du at intel.com>
    Original-Reviewed-by: Shawn N <shawnn at chromium.org>
---
 src/soc/intel/broadwell/pcie.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/broadwell/pcie.c b/src/soc/intel/broadwell/pcie.c
index 4476fe4..e217149 100644
--- a/src/soc/intel/broadwell/pcie.c
+++ b/src/soc/intel/broadwell/pcie.c
@@ -321,12 +321,12 @@ static void root_port_commit_config(void)
 		do {
 			reg32 = pci_read_config32(dev, 0x328);
 			n++;
-			if (((reg32 & 0xff000000) == 0x01000000) || (n > 500))
+			if (((reg32 & 0xff000000) == 0x01000000) || (n > 50))
 				break;
 			udelay(100);
 		} while (1);
 
-		if (n > 500)
+		if (n > 50)
 			printk(BIOS_DEBUG, "%s: Timeout waiting for 328h\n",
 				dev_path(dev));
 



More information about the coreboot-gerrit mailing list