[coreboot-gerrit] New patch to review for coreboot: 32e54f4 fmap: use CBFS for all other than x86 platforms

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Wed Apr 8 22:29:02 CEST 2015


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9436

-gerrit

commit 32e54f40194f76f51ac5fc3dd9b48df5858c5e45
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Tue Oct 28 18:26:12 2014 -0700

    fmap: use CBFS for all other than x86 platforms
    
    The architectiure check in fmap.c is in fact used to delineate between
    platforms where SPI flash is mapped to memory address space and where
    it needs to be accessed through CBFS.
    
    In fact cosmos board uses an ARM SOC which also maps SPI flash to
    processor address space, this will have to be addressed when that
    SOC's support is introduced, for now let's just presume that all but
    X86 platforms require CBFS layer to access fmap.
    
    BRANCH=none
    BUG=chrome-os-partner:31438
    TEST=none
    
    Original-Change-Id: Id135dc63278555a7fc5039a568fb28864f7cb8d1
    Original-Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/226180
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    
    (cherry picked from commit b3c04f84504380066c54a6dec93781a4f25a5fc6)
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    
    Change-Id: I3a0a70fe583b69b1c9cd8729817bd7062126e1a9
---
 src/vendorcode/google/chromeos/fmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vendorcode/google/chromeos/fmap.c b/src/vendorcode/google/chromeos/fmap.c
index 7c1f626..7c256ce 100644
--- a/src/vendorcode/google/chromeos/fmap.c
+++ b/src/vendorcode/google/chromeos/fmap.c
@@ -41,7 +41,7 @@ const struct fmap *fmap_find(void)
 	/* wrapping around 0x100000000 */
 	const struct fmap *fmap = (void *)
 		(CONFIG_FLASHMAP_OFFSET - CONFIG_ROM_SIZE);
-#elif CONFIG_ARCH_ARM
+#else
 	struct cbfs_media default_media, *media;
 	media = &default_media;
 	init_default_cbfs_media(media);



More information about the coreboot-gerrit mailing list