[coreboot-gerrit] Patch set updated for coreboot: e6e694f rk3288: don't log LAST_TSHUT bit

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Apr 8 13:31:19 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9409

-gerrit

commit e6e694fc0d45ae19038d8cd5c4bf8b6a33ee36be
Author: huang lin <hl at rock-chips.com>
Date:   Fri Nov 7 10:56:35 2014 +0800

    rk3288: don't log LAST_TSHUT bit
    
    Since the LAST_THSUT bit is uncertain value when it cold-reboot,
    we remove the printout about this status bit in coreboot.
    
    BUG=chrome-os-partner:33521
    TEST=Boot on veyron_pinky rev2
    
    Change-Id: I3b9791ffdffeff0721e3d86378db6255c5abc9ea
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 16464d3229ad1001952ef1b50fe3e606d1583462
    Original-Change-Id: I258750797e32c28f86e73a01eede005e890a6906
    Original-Signed-off-by: huang lin <hl at rock-chips.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/228391
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/soc/rockchip/rk3288/tsadc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/soc/rockchip/rk3288/tsadc.c b/src/soc/rockchip/rk3288/tsadc.c
index b7d8e9d..a2d6ec4 100644
--- a/src/soc/rockchip/rk3288/tsadc.c
+++ b/src/soc/rockchip/rk3288/tsadc.c
@@ -88,11 +88,7 @@ void tsadc_init(void)
 {
 	rkclk_configure_tsadc(TSADC_CLOCK_HZ);
 
-	if (readl(&rk3288_tsadc->auto_con) & LAST_TSHUT) {
-		printk(BIOS_WARNING, "last shutdown/rebot was caused "
-				"by over-temperature hardware trigger!\n");
-		setbits_le32(&rk3288_tsadc->auto_con, LAST_TSHUT);
-	}
+	setbits_le32(&rk3288_tsadc->auto_con, LAST_TSHUT);
 
 	setbits_le32(&rk3288_tsadc->int_en,
 			TSHUT_CRU_EN_SRC2 | TSHUT_CRU_EN_SRC1 |



More information about the coreboot-gerrit mailing list