[coreboot-gerrit] Patch merged into coreboot/master: 7a453eb rk3288: Change all SoC headers to <soc/headername.h> system

gerrit at coreboot.org gerrit at coreboot.org
Wed Apr 8 09:28:53 CEST 2015


the following patch was just integrated into master:
commit 7a453ebed2b87780100391b7ab78d41337890a66
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Oct 20 13:14:55 2014 -0700

    rk3288: Change all SoC headers to <soc/headername.h> system
    
    This patch is the start of a series to change all non-x86 SoC-specific
    headers to be included as <soc/header.h> instead of the old
    <soc/vendor/chip/header.h> or "header.h". It will add an include/soc/
    directory under every src/soc/vendor/chip/ and append the .../include/
    part of that to the global include path.
    
    This matches the usage of <arch/header.h> for architecture-specific
    headers and had already been done for some headers on Tegra. It has the
    advantage that a source file which does not know the specific SoC used
    (e.g. Tegra files common for multiple chips, or a global include file)
    can still include SoC-specific headers and access macros/types defined
    there. It also makes the includes for mainboard files more readable, and
    reduces the chance to pull in a wrong header when copying mainboard
    sources to use a different-related SoC (e.g. using a Tegra124 mainboard
    as template for a Tegra132 one).
    
    For easier maintainability, every SoC family is modified individually.
    This patch starts out by changing Rk3288. Also alphabetized headers in
    affected files since we touch them anyway.
    
    BUG=None
    TEST=Whole series: compared binary images for Daisy, Nyan_Blaze,
    Rush_Ryu, Storm, Urara and Veyron_Pinky. Confirmed that they are
    byte-for-byte identical except for timestamps, hashes, and __LINE__
    macro replacements. Compile-tested individual patches.
    
    Change-Id: I4d74a0c56be278e591a9cf43f93e9900e41f4319
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4ad8b6d2e0280428aa9742f0f7b723c00857334a
    Original-Change-Id: I415b8dbe735e572d4ae2cb1df62d66bcce386fff
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/222025
    Reviewed-on: http://review.coreboot.org/9349
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9349 for details.

-gerrit



More information about the coreboot-gerrit mailing list