[coreboot-gerrit] Patch merged into coreboot/master: 8c5e4d9 cbfs: Enforce media->map() result checking, improve error messages

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 7 23:02:19 CEST 2015


the following patch was just integrated into master:
commit 8c5e4d93db845fc1942438d54eedbdefcfd2bbf9
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Oct 10 14:11:11 2014 -0700

    cbfs: Enforce media->map() result checking, improve error messages
    
    If you try to boot a VBOOT2_VERIFY_FIRMWARE with less than 4K CBFS cache
    right now, your system will try and fail to validate the FMAP signature
    at (u8 *)0xFFFFFFFF and go into recovery mode. This patch avoids the
    memcmp() to potentially invalid memory, and also adds an error message
    to cbfs_simple_buffer_map() to make it explicit that we ran out of CBFS
    cache space.
    
    BUG=None
    TEST=Booted on Veyron_Pinky with reduced CBFS cache, saw the message.
    
    Original-Change-Id: Ic5773b4e0b36dc621513f58fc9bd29c17afbf1b7
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/222899
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    
    (cherry picked from commit 0ed3c0c2b63be0d32e8162faf892e41cef1f1f23)
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    
    Change-Id: I20ccac83bff4a377caca6327d0e21032efff44c1
    Reviewed-on: http://review.coreboot.org/9373
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/9373 for details.

-gerrit



More information about the coreboot-gerrit mailing list