[coreboot-gerrit] New patch to review for coreboot: 0ee3082 tegra132: Remove clamp_tristate_inputs() call

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Apr 7 13:25:13 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9346

-gerrit

commit 0ee308248f48c8798a3fa28137fbdc8353e9ef51
Author: Tom Warren <twarren at nvidia.com>
Date:   Fri Oct 17 10:27:09 2014 -0700

    tegra132: Remove clamp_tristate_inputs() call
    
    As per NV SysEng, setting PINMUX_CLAMP_INPUTS=1 is now
    considered a bad thing. It clamps _all_ tristated inputs
    to zero, and isn't really the panacea for duplicated pinmux
    mappings as was stated previously.
    
    BUG=None
    BRANCH=None
    TEST=Built both Rush and Ryu OK. Tested on Rush, booted kernel
    OK.
    
    Change-Id: I7d6982a18a772efda7f1d3bf0dcb0d4d0a5bed8f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: c5f77fa31961d39dd7b4bd2902288ead9ad80100
    Original-Change-Id: I566c4516b34686b744a47a2b0c18c4b801456727
    Original-Signed-off-by: Tom Warren <twarren at nvidia.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/224032
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/nvidia/tegra132/bootblock.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/soc/nvidia/tegra132/bootblock.c b/src/soc/nvidia/tegra132/bootblock.c
index 6f25050..0394c78 100644
--- a/src/soc/nvidia/tegra132/bootblock.c
+++ b/src/soc/nvidia/tegra132/bootblock.c
@@ -59,9 +59,6 @@ void __attribute__((weak)) bootblock_mainboard_early_init(void)
 
 void main(void)
 {
-	// enable pinmux clamp inputs
-	clamp_tristate_inputs();
-
 	// enable JTAG at the earliest stage
 	enable_jtag();
 



More information about the coreboot-gerrit mailing list