[coreboot-gerrit] Patch merged into coreboot/master: 1f5349e nvramtool: fix getopt handling with unsigned char

gerrit at coreboot.org gerrit at coreboot.org
Mon Apr 6 23:29:08 CEST 2015


the following patch was just integrated into master:
commit 1f5349e61d8aea950d6a197d11b0aa730aa80ee6
Author: Stefan Tauner <stefan.tauner at gmx.at>
Date:   Sun Apr 5 23:13:53 2015 +0200

    nvramtool: fix getopt handling with unsigned char
    
    make failed while executing "OPTION     option_table.h" by printing
    nvramtool's usage message when crosscompiling coreboot on the BBB.
    The reason is the usage of char for the return value of getopt instead
    of int and comparing it to -1 later... although char might be unsigned
    as it is usually on ARM.
    
    Change-Id: Ib20fd5ef174d484bbb35f80150b8f898d95d0fe4
    Signed-off-by: Stefan Tauner <stefan.tauner at gmx.at>
    Reviewed-on: http://review.coreboot.org/9307
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/9307 for details.

-gerrit



More information about the coreboot-gerrit mailing list