[coreboot-gerrit] New patch to review for coreboot: db80d46 kconfig: use va_end to match corresponding va_start

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Mon Apr 6 01:47:58 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9309

-gerrit

commit db80d46adcc31fbd44941227bd57dc7ed66e9b97
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Mon Apr 6 01:14:21 2015 +0200

    kconfig: use va_end to match corresponding va_start
    
    Although on some systems va_end is a no-op, it is good practice
    to use va_end, especially since the manual states:
    
    "Each invocation of va_start() must be matched by a corresponding
    invocation of va_end() in the same function."
    
    Signed-off-by: Colin Ian King <colin.king at canonical.com>
    Signed-off-by: Michal Marek <mmarek at suse.cz>
    
    Change-Id: Ia08a57c37a6294e002cb6ce4c0a010c0d2edf973
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/kconfig/confdata.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/kconfig/confdata.c b/util/kconfig/confdata.c
index 149e27a..235debf 100644
--- a/util/kconfig/confdata.c
+++ b/util/kconfig/confdata.c
@@ -59,6 +59,7 @@ static void conf_message(const char *fmt, ...)
 	va_start(ap, fmt);
 	if (conf_message_callback)
 		conf_message_callback(fmt, ap);
+	va_end(ap);
 }
 
 const char *conf_get_configname(void)



More information about the coreboot-gerrit mailing list