[coreboot-gerrit] New patch to review for coreboot: 31d0870 Broadwell: Fix PCIe L1 Sub-State capability ID not filled.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Apr 2 23:52:31 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9267

-gerrit

commit 31d08702e0b5e30a2f84954ac97fc058509d4cfb
Author: Kenji Chen <kenji.chen at intel.com>
Date:   Tue Sep 30 14:17:35 2014 +0800

    Broadwell: Fix PCIe L1 Sub-State capability ID not filled.
    
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: 31d7276fbdca67937bcdf0d5c2af371a2fd1a510
    Original-BUG=chrome-os-partner:31424,chromeos-os-partner:32380
    Original-TEST=Build a BIOS image and check the value is applied correctly.
    Original-Signed-off-by: Kenji Chen <kenji.chen at intel.com>
    Original-Change-Id: I0adda3643776b259a635a021babd983090f1df43
    Original-Reviewed-on: https://chromium-review.googlesource.com/220475
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    
    Change-Id: Id88c11ed128b44c3a60ef1a141b99071c1ee15d3
---
 src/soc/intel/broadwell/pcie.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/broadwell/pcie.c b/src/soc/intel/broadwell/pcie.c
index 4e5bbfa..10b6230 100644
--- a/src/soc/intel/broadwell/pcie.c
+++ b/src/soc/intel/broadwell/pcie.c
@@ -558,9 +558,12 @@ static void pch_pcie_early(struct device *dev)
 
 	pcie_update_cfg8(dev, 0xf5, 0x0f, 0);
 
-	/* Set Extended Capability to offset 200h and Advanced Error Report. */
+	/* Set AER Extended Cap ID to 01h and Next Cap Pointer to 200h. */
 	pcie_update_cfg(dev, 0x100, ~(1 << 29) & ~0xfffff, (1 << 29) | 0x10001);
 
+	/* Set L1 Sub-State Cap ID to 1Eh and Next Cap Pointer to None. */
+	pcie_update_cfg(dev, 0x200, ~0xffff, 0x001e);
+
 	pcie_update_cfg(dev, 0x320, ~(3 << 20) & ~(7 << 6),
 		(1 << 20) | (3 << 6));
 	/* Enable Relaxed Order from Root Port. */



More information about the coreboot-gerrit mailing list