[coreboot-gerrit] Patch merged into coreboot/master: 635ee51 arm: Prevent compilation of old, experimental SMP support

gerrit at coreboot.org gerrit at coreboot.org
Thu Apr 2 17:28:04 CEST 2015


the following patch was just integrated into master:
commit 635ee51b0d5cffc155e09fbbe644c2914ce54b6a
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Sep 23 20:53:20 2014 -0700

    arm: Prevent compilation of old, experimental SMP support
    
    The ARM SMP feature was added a long time ago and has never really been
    used by anyone since. We are still always compiling cpu_info() even
    though we don't use it, and it makes some dangerous assumptions about
    stack alignment that are not guaranteed anywhere.
    
    I'm planning to change the way the stack boundaries are defined. Rather
    than trying to work that into this unsafe, unused and hard to test
    feature, I think we should just seal it off with police tape and make
    sure that if anyone ever tries to use it again (which currently seems
    unlikely), they get forced to do their due diligence on making sure it
    works as intended.
    
    BUG=None
    TEST=Compiled Veyron_Pinky.
    
    Change-Id: Id25545cab88f29200c7672ef02c7804f0ac26399
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: 5b517fc46b030a6e50ef2f5e4d4a449b98ce16c6
    Original-Change-Id: I8a60bd30e8b27a22bb3da68ca84daea99424dee9
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/219680
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/9222
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/9222 for details.

-gerrit



More information about the coreboot-gerrit mailing list