[coreboot-gerrit] New patch to review for coreboot: 6fc0572 broadwell: me: Fix typo and add missing phase state

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Apr 1 23:37:27 CEST 2015


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9225

-gerrit

commit 6fc057274766b9dfe1732ddf267d5066f083a692
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Thu Oct 9 16:14:39 2014 -0700

    broadwell: me: Fix typo and add missing phase state
    
    Fix the typo of sate to state and add uKernel phase to just
    output the current state byte.
    
    BUG=chrome-os-partner:28234
    BRANCH=samus,auron
    TEST=build and boot on samus
    
    Change-Id: I5f341ee6c58487aeb927cab0641742cb4071a6b7
    Signed-off-by: Stefan Reinauer <reinauer at chromium.org>
    Original-Commit-Id: de6149508c50d0770fedfbe352e9149abea87b4c
    Original-Change-Id: I520a4cc75faffa5feeb6113ffd7b07a48c4e6f28
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/222677
    Original-Reviewed-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/broadwell/me_status.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/broadwell/me_status.c b/src/soc/intel/broadwell/me_status.c
index 4dfbeae..31eff3c 100644
--- a/src/soc/intel/broadwell/me_status.c
+++ b/src/soc/intel/broadwell/me_status.c
@@ -248,6 +248,10 @@ void intel_me_status(void)
 		       me_progress_rom_values[hfs2->current_state]);
 		break;
 
+	case ME_HFS2_PHASE_UKERNEL:	/* uKernel Phase */
+		printk(BIOS_DEBUG, "0x%02x", hfs2->current_state);
+		break;
+
 	case ME_HFS2_PHASE_BUP:		/* Bringup Phase */
 		if (hfs2->current_state < ARRAY_SIZE(me_progress_bup_values)
 		    && me_progress_bup_values[hfs2->current_state])
@@ -274,7 +278,7 @@ void intel_me_status(void)
 		break;
 
 	default:
-		printk(BIOS_DEBUG, "Unknown phase: 0x%02x sate: 0x%02x",
+		printk(BIOS_DEBUG, "Unknown phase: 0x%02x state: 0x%02x",
 		       hfs2->progress_code, hfs2->current_state);
 	}
 	printk(BIOS_DEBUG, "\n");



More information about the coreboot-gerrit mailing list