[coreboot-gerrit] Patch set updated for coreboot: 8dde0c2 x86: set smbios rom size based on CONFIG_ROM_SIZE

Aaron Durbin (adurbin@google.com) gerrit at coreboot.org
Wed Apr 1 21:43:39 CEST 2015


Aaron Durbin (adurbin at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9130

-gerrit

commit 8dde0c2d2dcaaf822402f870bd4a7a49f1960983
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Mar 26 14:55:34 2015 -0500

    x86: set smbios rom size based on CONFIG_ROM_SIZE
    
    Instead of relying on the CBFS header's romsize field use
    the CONFIG_ROM_SIZE Kconfig variable. That value is what is
    used to create the rom file as it is. Therefore, just remove
    the dependency.
    
    Change-Id: If855d7378df20080061e27e4988e96aee233d1e0
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/x86/boot/smbios.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c
index 4b96d61..4c3490d 100644
--- a/src/arch/x86/boot/smbios.c
+++ b/src/arch/x86/boot/smbios.c
@@ -28,7 +28,6 @@
 #include <device/device.h>
 #include <arch/cpu.h>
 #include <cpu/x86/name.h>
-#include <cbfs_core.h>
 #include <arch/byteorder.h>
 #include <elog.h>
 #include <memory_info.h>
@@ -258,14 +257,7 @@ static int smbios_write_type0(unsigned long *current, int handle)
 	vboot_data->vbt10 = (u32)t->eos + (version_offset - 1);
 #endif
 
-	{
-		const struct cbfs_header *header;
-		u32 romsize = CONFIG_ROM_SIZE;
-		header = cbfs_get_header(CBFS_DEFAULT_MEDIA);
-		if (header != CBFS_HEADER_INVALID_ADDRESS)
-			romsize = ntohl(header->romsize);
-		t->bios_rom_size = (romsize / 65535) - 1;
-	}
+	t->bios_rom_size = (CONFIG_ROM_SIZE / 65535) - 1;
 
 	t->system_bios_major_release = 4;
 	t->bios_characteristics =



More information about the coreboot-gerrit mailing list