[coreboot-gerrit] New patch to review for coreboot: 49742cb google/{falco, peppy}/gma.c: Do not include non-existent "hda.h"
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sun Sep 21 11:56:36 CEST 2014
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6946
-gerrit
commit 49742cbefaf3d0f5089980f270857ce9d08ba948
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sun Sep 21 11:53:56 2014 +0200
google/{falco,peppy}/gma.c: Do not include non-existent "hda.h"
Commit 75c83870 (azalia: Shrink boilerplate) [1] removed the header
file `hda_verb.h`. This header is still included in the mainboard’s
`gma.c`, causing the following build error, when native graphics
initialization is enabled.
CC mainboard/google/falco/gma.ramstage.o
src/mainboard/google/falco/gma.c:34:22: fatal error: hda_verb.h: No such file or directory
This was not caught, as native graphics initialization is not enabled
for the build tests.
It turns out that the array `mainboard_cim_verb_data` is not used in
`src/mainboard/intel/wtm2/hda_verb.h`, so fix the problem by removing
the inclusion.
[1] http://review.coreboot.org/6840
Change-Id: I91e4f00a3030bdef0278102df2783258389bca13
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/mainboard/google/falco/gma.c | 1 -
src/mainboard/google/peppy/gma.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/src/mainboard/google/falco/gma.c b/src/mainboard/google/falco/gma.c
index 4e32b28..4a5b7d0 100644
--- a/src/mainboard/google/falco/gma.c
+++ b/src/mainboard/google/falco/gma.c
@@ -31,7 +31,6 @@
#include <arch/io.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
-#include "hda_verb.h"
#include <smbios.h>
#include <device/pci.h>
#include <ec/google/chromeec/ec.h>
diff --git a/src/mainboard/google/peppy/gma.c b/src/mainboard/google/peppy/gma.c
index 9b8a32b..0e954e0 100644
--- a/src/mainboard/google/peppy/gma.c
+++ b/src/mainboard/google/peppy/gma.c
@@ -31,7 +31,6 @@
#include <arch/io.h>
#include <arch/interrupt.h>
#include <boot/coreboot_tables.h>
-#include "hda_verb.h"
#include <smbios.h>
#include <device/pci.h>
#include <ec/google/chromeec/ec.h>
More information about the coreboot-gerrit
mailing list