[coreboot-gerrit] New patch to review for coreboot: a662749 build system: only do the compiler test for gcc

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Nov 28 23:18:30 CET 2014


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7607

-gerrit

commit a66274970de7a9ebcf80abe437441d301a0cd7e4
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Fri Nov 28 23:08:51 2014 +0100

    build system: only do the compiler test for gcc
    
    There isn't a history of broken clang compilers yet,
    (except for versions that aren't compatible enough,)
    so let's give it a chance.
    
    Change-Id: Iddb63700e3850116313c1ddee69111f936191055
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
 Makefile.inc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 3719dd5..a925d67 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -26,17 +26,17 @@ export KERNELVERSION := $(shell if [ -d "$(top)/.git" -a -f "`which git`" ]; \
 #######################################################################
 # Test for coreboot toolchain (except when explicitely not requested)
 ifneq ($(NOCOMPILE),1)
-# only run if we're doing a build (not for tests, kconfig, ...)
+# only run if we're doing a build (not for tests, kconfig, ...), using gcc
+# rationale: gcc versions by Linux distributions tend to be quite messed up
+ifeq ($(CONFIG_COMPILER_GCC),y)
 ifneq ($(CONFIG_ANY_TOOLCHAIN),y)
 _toolchain=$(shell $(CC_x86_32) -v 2>&1 |grep -q "gcc version .*coreboot toolchain" && echo coreboot)
-ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
-_toolchain=$(shell $(CC_x86_32) -v 2>&1 |grep -q "clang version" && echo coreboot)
-endif
 ifneq ($(_toolchain),coreboot)
 $(error Please use the coreboot toolchain (or prove that your toolchain works))
 endif
 endif
 endif
+endif
 
 #######################################################################
 # Basic component discovery



More information about the coreboot-gerrit mailing list