[coreboot-gerrit] New patch to review for coreboot: 65a27cd northbridge/amd/agesa/family*/dimmSpd.c: Use NULL over 0

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Fri Nov 28 09:55:56 CET 2014


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7591

-gerrit

commit 65a27cd701571df638f11e2b104ae9a37c7d5b64
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Nov 28 19:54:34 2014 +1100

    northbridge/amd/agesa/family*/dimmSpd.c: Use NULL over 0
    
    Change-Id: I578631c319ccc8fc133abc29b5a9e9b59e584b87
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/amd/agesa/family14/dimmSpd.c   | 2 +-
 src/northbridge/amd/agesa/family15/dimmSpd.c   | 2 +-
 src/northbridge/amd/agesa/family15rl/dimmSpd.c | 2 +-
 src/northbridge/amd/agesa/family15tn/dimmSpd.c | 2 +-
 src/northbridge/amd/agesa/family16kb/dimmSpd.c | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.c b/src/northbridge/amd/agesa/family14/dimmSpd.c
index 6ca2ce1..0423386 100644
--- a/src/northbridge/amd/agesa/family14/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family14/dimmSpd.c
@@ -59,7 +59,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 	spdAddress = config->spdAddrLookup
 		[info->SocketId][info->MemChannelId][info->DimmId];
 
-	if (spdAddress == 0)
+	if (spdAddress == NULL)
 		return AGESA_ERROR;
 
 	int err = smbus_readSpd(spdAddress, (void *) info->Buffer, 128);
diff --git a/src/northbridge/amd/agesa/family15/dimmSpd.c b/src/northbridge/amd/agesa/family15/dimmSpd.c
index bf8e59e..98213e2 100644
--- a/src/northbridge/amd/agesa/family15/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family15/dimmSpd.c
@@ -59,7 +59,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 	spdAddress = config->spdAddrLookup
 		[info->SocketId][info->MemChannelId][info->DimmId];
 
-	if (spdAddress == 0)
+	if (spdAddress == NULL)
 		return AGESA_ERROR;
 
 	int err = smbus_readSpd(spdAddress, (void *) info->Buffer, 256);
diff --git a/src/northbridge/amd/agesa/family15rl/dimmSpd.c b/src/northbridge/amd/agesa/family15rl/dimmSpd.c
index b8d7026..b970ba7 100644
--- a/src/northbridge/amd/agesa/family15rl/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family15rl/dimmSpd.c
@@ -56,7 +56,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 	spdAddress = config->spdAddrLookup
 		[info->SocketId][info->MemChannelId][info->DimmId];
 
-	if (spdAddress == 0)
+	if (spdAddress == NULL)
 		return AGESA_ERROR;
 
 	int err = hudson_readSpd(spdAddress, (void *) info->Buffer, 128);
diff --git a/src/northbridge/amd/agesa/family15tn/dimmSpd.c b/src/northbridge/amd/agesa/family15tn/dimmSpd.c
index 25f2a14..983b4da 100644
--- a/src/northbridge/amd/agesa/family15tn/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family15tn/dimmSpd.c
@@ -55,7 +55,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 	spdAddress = config->spdAddrLookup
 		[info->SocketId][info->MemChannelId][info->DimmId];
 
-	if (spdAddress == 0)
+	if (spdAddress == NULL)
 		return AGESA_ERROR;
 
 	int err = hudson_readSpd(spdAddress, (void *) info->Buffer, 128);
diff --git a/src/northbridge/amd/agesa/family16kb/dimmSpd.c b/src/northbridge/amd/agesa/family16kb/dimmSpd.c
index 6ffdf5d..8c91e14 100644
--- a/src/northbridge/amd/agesa/family16kb/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family16kb/dimmSpd.c
@@ -55,7 +55,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINT32 unused2, AGESA_READ_SPD_PA
 	spdAddress = config->spdAddrLookup
 		[info->SocketId][info->MemChannelId][info->DimmId];
 
-	if (spdAddress == 0)
+	if (spdAddress == NULL)
 		return AGESA_ERROR;
 
 	int err = hudson_readSpd(spdAddress, (void *) info->Buffer, 128);



More information about the coreboot-gerrit mailing list