[coreboot-gerrit] Patch set updated for coreboot: 00a8ed2 speedstep: Don't supply weak get_cst_entries.

[Ronald G. Minnich (rminnich@gmail.com)]

Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7368

-gerrit

commit 00a8ed2b9b52bdf510c8ad72ed64751bae6573e2
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Sun Nov 9 12:59:29 2014 +0100

    speedstep: Don't supply weak get_cst_entries.
    
    This should be overriden by mobo even if it's no-op override.
    A weak function in this case would only hide real problems.
    
    Change-Id: I30dd671eb605b490a51153d00ae308c4bdef3d05
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/cpu/intel/speedstep/acpi.c                | 13 -------------
 src/mainboard/getac/p470/Makefile.inc         |  1 +
 src/mainboard/getac/p470/cstates.c            |  7 +++++++
 src/mainboard/ibase/mb899/Makefile.inc        |  1 +
 src/mainboard/ibase/mb899/cstates.c           |  7 +++++++
 src/mainboard/intel/d945gclf/Makefile.inc     |  1 +
 src/mainboard/intel/d945gclf/cstates.c        |  7 +++++++
 src/mainboard/intel/eagleheights/Makefile.inc |  1 +
 src/mainboard/intel/eagleheights/cstates.c    |  7 +++++++
 src/mainboard/iwave/iWRainbowG6/Makefile.inc  |  1 +
 src/mainboard/iwave/iWRainbowG6/cstates.c     |  7 +++++++
 src/mainboard/kontron/986lcd-m/Makefile.inc   |  1 +
 src/mainboard/kontron/986lcd-m/cstates.c      |  7 +++++++
 src/mainboard/roda/rk886ex/Makefile.inc       |  1 +
 src/mainboard/roda/rk886ex/cstates.c          |  7 +++++++
 15 files changed, 56 insertions(+), 13 deletions(-)

diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c
index 8a2bff1..0217f71 100644
--- a/src/cpu/intel/speedstep/acpi.c
+++ b/src/cpu/intel/speedstep/acpi.c
@@ -29,19 +29,6 @@
 #include <cpu/intel/speedstep.h>
 #include <device/device.h>
 
-/**
- * @brief Returns c-state entries for this system
- *
- * This function is usually overwritten in mainboard code.
- *
- * @return Number of c-states *entries will point to.
- */
-int __attribute__((weak)) get_cst_entries(acpi_cstate_t **entries
-					  __attribute__((unused)))
-{
-	return 0;
-}
-
 static int determine_total_number_of_cores(void)
 {
 	struct device *cpu;
diff --git a/src/mainboard/getac/p470/Makefile.inc b/src/mainboard/getac/p470/Makefile.inc
index 1ba662e..39c6a2b 100644
--- a/src/mainboard/getac/p470/Makefile.inc
+++ b/src/mainboard/getac/p470/Makefile.inc
@@ -17,3 +17,4 @@
 ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
 ##
 
+ramstage-y += cstates.c
diff --git a/src/mainboard/getac/p470/cstates.c b/src/mainboard/getac/p470/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/getac/p470/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}
diff --git a/src/mainboard/ibase/mb899/Makefile.inc b/src/mainboard/ibase/mb899/Makefile.inc
index c4e781b..0b70b89 100644
--- a/src/mainboard/ibase/mb899/Makefile.inc
+++ b/src/mainboard/ibase/mb899/Makefile.inc
@@ -1 +1,2 @@
 ramstage-y += superio_hwm.c
+ramstage-y += cstates.c
diff --git a/src/mainboard/ibase/mb899/cstates.c b/src/mainboard/ibase/mb899/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/ibase/mb899/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}
diff --git a/src/mainboard/intel/d945gclf/Makefile.inc b/src/mainboard/intel/d945gclf/Makefile.inc
new file mode 100644
index 0000000..f9621db
--- /dev/null
+++ b/src/mainboard/intel/d945gclf/Makefile.inc
@@ -0,0 +1 @@
+ramstage-y += cstates.c
diff --git a/src/mainboard/intel/d945gclf/cstates.c b/src/mainboard/intel/d945gclf/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/intel/d945gclf/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}
diff --git a/src/mainboard/intel/eagleheights/Makefile.inc b/src/mainboard/intel/eagleheights/Makefile.inc
new file mode 100644
index 0000000..f9621db
--- /dev/null
+++ b/src/mainboard/intel/eagleheights/Makefile.inc
@@ -0,0 +1 @@
+ramstage-y += cstates.c
diff --git a/src/mainboard/intel/eagleheights/cstates.c b/src/mainboard/intel/eagleheights/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/intel/eagleheights/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}
diff --git a/src/mainboard/iwave/iWRainbowG6/Makefile.inc b/src/mainboard/iwave/iWRainbowG6/Makefile.inc
new file mode 100644
index 0000000..f9621db
--- /dev/null
+++ b/src/mainboard/iwave/iWRainbowG6/Makefile.inc
@@ -0,0 +1 @@
+ramstage-y += cstates.c
diff --git a/src/mainboard/iwave/iWRainbowG6/cstates.c b/src/mainboard/iwave/iWRainbowG6/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/iwave/iWRainbowG6/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}
diff --git a/src/mainboard/kontron/986lcd-m/Makefile.inc b/src/mainboard/kontron/986lcd-m/Makefile.inc
new file mode 100644
index 0000000..f9621db
--- /dev/null
+++ b/src/mainboard/kontron/986lcd-m/Makefile.inc
@@ -0,0 +1 @@
+ramstage-y += cstates.c
diff --git a/src/mainboard/kontron/986lcd-m/cstates.c b/src/mainboard/kontron/986lcd-m/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/kontron/986lcd-m/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}
diff --git a/src/mainboard/roda/rk886ex/Makefile.inc b/src/mainboard/roda/rk886ex/Makefile.inc
index 7a05dc3..402b4f5 100644
--- a/src/mainboard/roda/rk886ex/Makefile.inc
+++ b/src/mainboard/roda/rk886ex/Makefile.inc
@@ -18,3 +18,4 @@
 ##
 
 ramstage-y += m3885.c
+ramstage-y += cstates.c
diff --git a/src/mainboard/roda/rk886ex/cstates.c b/src/mainboard/roda/rk886ex/cstates.c
new file mode 100644
index 0000000..2d543ff
--- /dev/null
+++ b/src/mainboard/roda/rk886ex/cstates.c
@@ -0,0 +1,7 @@
+#include <device/device.h>
+#include <arch/x86/include/arch/acpigen.h>
+
+int get_cst_entries(acpi_cstate_t **entries)
+{
+	return 0;
+}