[coreboot-gerrit] Patch set updated for coreboot: 4a060c9 google/butterfly: fix off-by-one issues
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Nov 24 22:01:01 CET 2014
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7577
-gerrit
commit 4a060c9772a29a221e30353df937cfefd12a57a3
Author: Patrick Georgi <patrick at georgi-clan.de>
Date: Mon Nov 24 21:59:03 2014 +0100
google/butterfly: fix off-by-one issues
GPIOs 32 and 64 used the wrong code path.
Change-Id: I1d293cf38844b477cac67bc19ce5e5c92a6e93ca
Found-by: Coverity Scan
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
src/mainboard/google/butterfly/chromeos.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/google/butterfly/chromeos.c b/src/mainboard/google/butterfly/chromeos.c
index 61097c3..ecb1288 100644
--- a/src/mainboard/google/butterfly/chromeos.c
+++ b/src/mainboard/google/butterfly/chromeos.c
@@ -112,10 +112,10 @@ int get_pch_gpio(unsigned char gpio_num)
if (!gpio_base)
return(0);
- if (gpio_num > 64){
+ if (gpio_num >= 64){
u32 gp_lvl3 = inl(gpio_base + GP_LVL3);
retval = ((gp_lvl3 >> (gpio_num - 64)) & 1);
- } else if (gpio_num > 32){
+ } else if (gpio_num >= 32){
u32 gp_lvl2 = inl(gpio_base + GP_LVL2);
retval = ((gp_lvl2 >> (gpio_num - 32)) & 1);
} else {
More information about the coreboot-gerrit
mailing list