[coreboot-gerrit] Patch set updated for coreboot: a27a45c northbridge/amd/agesa/family15: Remove redundant prototype

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sat Nov 22 13:13:06 CET 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7531

-gerrit

commit a27a45c3fa59ff2f80e192da69463a8ba663e742
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Fri Nov 21 00:50:27 2014 +1100

    northbridge/amd/agesa/family15: Remove redundant prototype
    
    Function is static local only and so no need for a static
    prototype in header. Syncs header with other families also.
    
    Change-Id: I540aeafb8528e229700b6d596d4d8094c22e7625
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/amd/agesa/family15/northbridge.c | 15 +++++++--------
 src/northbridge/amd/agesa/family15/northbridge.h |  1 -
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/northbridge/amd/agesa/family15/northbridge.c b/src/northbridge/amd/agesa/family15/northbridge.c
index 405e9b4..aef70f4 100644
--- a/src/northbridge/amd/agesa/family15/northbridge.c
+++ b/src/northbridge/amd/agesa/family15/northbridge.c
@@ -833,6 +833,13 @@ static void domain_set_resources(device_t dev)
 	}
 }
 
+/* all family15's pci devices are under 0x18.0, so we search from dev 0x18 fun 0 */
+static unsigned int f15_pci_domain_scan_bus(device_t dev, unsigned int max)
+{
+	max = pci_scan_bus(dev->link_list, PCI_DEVFN(0x18, 0), 0xff, max);
+	return max;
+}
+
 static struct device_operations pci_domain_ops = {
 	.read_resources	  = domain_read_resources,
 	.set_resources	  = domain_set_resources,
@@ -1102,15 +1109,7 @@ static void root_complex_enable_dev(struct device *dev)
 	}
 }
 
-
 struct chip_operations northbridge_amd_agesa_family15_root_complex_ops = {
 	CHIP_NAME("AMD FAM15 Root Complex")
 	.enable_dev = root_complex_enable_dev,
 };
-
-/* all family15's pci devices are under 0x18.0, so we search from dev 0x18 fun 0 */
-static unsigned int f15_pci_domain_scan_bus(device_t dev, unsigned int max)
-{
-	max = pci_scan_bus(dev->link_list, PCI_DEVFN(0x18, 0), 0xff, max);
-	return max;
-}
diff --git a/src/northbridge/amd/agesa/family15/northbridge.h b/src/northbridge/amd/agesa/family15/northbridge.h
index 99fdcae..9c655e6 100644
--- a/src/northbridge/amd/agesa/family15/northbridge.h
+++ b/src/northbridge/amd/agesa/family15/northbridge.h
@@ -22,6 +22,5 @@
 
 static struct device_operations pci_domain_ops;
 static struct device_operations cpu_bus_ops;
-static unsigned int f15_pci_domain_scan_bus(device_t dev, unsigned int max);
 
 #endif /* NORTHBRIDGE_AMD_AGESA_FAM15_H */



More information about the coreboot-gerrit mailing list